MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

ConditionalCanBeOptionalInspection: activate always on condition (even in information mode)

Browse Source 
Review ID: IDEA-CR-28692
This commit is contained in:
Tagir Valeev
2018-01-24 16:35:08 +07:00
parent ea54dc0e19
commit 4296de3a2e
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-impl/src/com/intellij/codeInspection/ConditionalCanBeOptionalInspection.java
+1 -3
View File
@@ -6,7 +6,6 @@ import com.intellij.codeInspection.dataFlow.NullnessUtil;
import com.intellij.codeInspection.util.LambdaGenerationUtil;
import com.intellij.codeInspection.util.OptionalUtil;
import com.intellij.openapi.project.Project;
import com.intellij.profile.codeInspection.InspectionProjectProfileManager;
import com.intellij.psi.*;
import com.intellij.psi.codeStyle.JavaCodeStyleManager;
import com.intellij.psi.search.LocalSearchScope;
@@ -48,8 +47,7 @@ public class ConditionalCanBeOptionalInspection extends AbstractBaseJavaLocalIns
boolean mayChangeSemantics =
!ExpressionUtils.isNullLiteral(nullBranch) && NullnessUtil.getExpressionNullness(notNullBranch, true) != Nullness.NOT_NULL;
if (!isOnTheFly && mayChangeSemantics) return;
boolean informationLevel = mayChangeSemantics || InspectionProjectProfileManager.isInformationLevel(getShortName(), ternary);
holder.registerProblem(informationLevel ? ternary : ternary.getCondition(),
holder.registerProblem(ternary.getCondition(),
"Can be replaced with Optional.ofNullable()",
mayChangeSemantics ? ProblemHighlightType.INFORMATION : ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
new ReplaceConditionWithOptionalFix(mayChangeSemantics));