Build scripts: builtin modules should contain only bundled plugins (IDEA-179418)

- do not take modules from product's main_module and scramble-related modules
This commit is contained in:
Alexander Zolotov
2017-09-26 20:13:45 +03:00
parent 7138f11b5b
commit 402b649dcd
2 changed files with 9 additions and 11 deletions
@@ -274,18 +274,18 @@ idea.fatal.error.notification=disabled
}
private compileModulesForDistribution(DistributionJARsBuilder distributionJARsBuilder) {
def bundledPlugins = buildContext.productProperties.productLayout.bundledPluginModules as Set<String>
def moduleNames = buildContext.productProperties.productLayout.getIncludedPluginModules(bundledPlugins) +
distributionJARsBuilder.platformModules +
buildContext.productProperties.additionalModulesToCompile +
(buildContext.proprietaryBuildTools.scrambleTool?.additionalModulesToCompile ?: [])
compileModules(moduleNames, buildContext.productProperties.modulesToCompileTests)
def productLayout = buildContext.productProperties.productLayout
def bundledPlugins = productLayout.bundledPluginModules as Set<String>
def moduleNames = productLayout.getIncludedPluginModules(bundledPlugins) +
distributionJARsBuilder.platformModules +
buildContext.productProperties.additionalModulesToCompile
compileModules(moduleNames + (buildContext.proprietaryBuildTools.scrambleTool?.additionalModulesToCompile ?: []) +
productLayout.mainModules, buildContext.productProperties.modulesToCompileTests)
def pluginsToPublish = distributionJARsBuilder.getPluginsByModules(buildContext.productProperties.productLayout.pluginModulesToPublish)
if (buildContext.shouldBuildDistributions()) {
def providedModulesFilePath = "${buildContext.paths.artifacts}/${buildContext.productProperties.productCode}-builtinModules.json"
buildProvidedModulesList(providedModulesFilePath, productLayout.mainModules, productLayout.licenseFilesToBuildSearchableOptions)
buildProvidedModulesList(providedModulesFilePath, moduleNames, productLayout.licenseFilesToBuildSearchableOptions)
if (buildContext.productProperties.productLayout.buildAllCompatiblePlugins) {
if (!buildContext.options.buildStepsToSkip.contains(BuildOptions.PROVIDED_MODULES_LIST_STEP)) {
pluginsToPublish = new PluginsCollector(buildContext, providedModulesFilePath).collectCompatiblePluginsToPublish()
@@ -145,9 +145,7 @@ class DistributionJARsBuilder {
List<String> getPlatformModules() {
(platform.moduleJars.values() as List<String>) +
["java-runtime", "platform-main", /*required to build searchable options index*/
"updater"] + buildContext.productProperties.productLayout.mainModules
["java-runtime", "platform-main", /*required to build searchable options index*/ "updater"]
}
void buildJARs() {