MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Java: fix NPE in "Call to native method while locked" inspection (IDEA-370235)

Browse Source 
GitOrigin-RevId: c1c84d6ba917823680ecd9a0729ebc278c2c27d6
This commit is contained in:
Bas Leijdekkers
2025-04-09 16:34:52 +00:00
committed by intellij-monorepo-bot
parent 988ea08386
commit 3f2c02fb00
2 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/siyeh/ig/threading/CallToNativeMethodWhileLockedInspection.java
+5 -6
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2003-2010 Dave Griffith, Bas Leijdekkers
* Copyright 2003-2025 Dave Griffith, Bas Leijdekkers
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -28,8 +28,7 @@ public final class CallToNativeMethodWhileLockedInspection extends BaseInspectio
@Override
protected @NotNull String buildErrorString(Object... infos) {
return InspectionGadgetsBundle.message(
"call.to.native.method.while.locked.problem.descriptor");
return InspectionGadgetsBundle.message("call.to.native.method.while.locked.problem.descriptor");
}
@Override
@@ -43,14 +42,14 @@ public final class CallToNativeMethodWhileLockedInspection extends BaseInspectio
Set.of(CommonClassNames.JAVA_LANG_OBJECT, "java.lang.System", "sun.misc.Unsafe", "java.lang.invoke.MethodHandle");
@Override
public void visitMethodCallExpression(
@NotNull PsiMethodCallExpression expression) {
public void visitMethodCallExpression(@NotNull PsiMethodCallExpression expression) {
final PsiMethod method = expression.resolveMethod();
if (method == null || !method.hasModifierProperty(PsiModifier.NATIVE)) return;
final PsiClass containingClass = method.getContainingClass();
if (containingClass == null) return;
if (EXCLUDED_CLASS_NAMES.contains(containingClass.getQualifiedName())) return;
String name = containingClass.getQualifiedName();
if (name != null && EXCLUDED_CLASS_NAMES.contains(name)) return;
if (!SynchronizationUtil.isInSynchronizedContext(expression)) return;
registerMethodCallError(expression);
java/java-tests/testData/ig/com/siyeh/igtest/threading/call_to_native_method_while_locked/CallToNativeMethodWhileLocked.java
+6
View File
@@ -9,6 +9,12 @@ public class CallToNativeMethodWhileLocked {
};
new Object() {
long l = Double.doubleToRawLongBits(42.0);
synchronized void x() {
<warning descr="Call to native method 'y()' in a synchronized context">y</warning>();
}
native void y();
};
Runnable s = () -> {
assert Thread.holdsLock(this);