MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-04-21 05:51:25 +07:00
Code Issues Packages Projects Releases Wiki Activity

[java-highlighting] IDEA-359187 LVTI: 'lambda expression requires an explicit target type' not highlighted as error when in parenthesis

Browse Source 
GitOrigin-RevId: 248072c38aeaf7f05b088c04bc435ecd0e940dd8
This commit is contained in:
Tagir Valeev
2024-10-01 16:43:10 +02:00
committed by intellij-monorepo-bot
parent e3d5629229
commit 3ec30c1c1b
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/HighlightUtil.java
View File

@@ -539,8 +539,9 @@ public final class HighlightUtil {
HighlightFixUtil.registerSpecifyVarTypeFix((PsiLocalVariable)variable, info);
return info;
}
if (initializer instanceof PsiFunctionalExpression) {
boolean lambda = initializer instanceof PsiLambdaExpression;
PsiExpression deparen = PsiUtil.skipParenthesizedExprDown(initializer);
if (deparen instanceof PsiFunctionalExpression) {
boolean lambda = deparen instanceof PsiLambdaExpression;
String message = JavaErrorBundle.message(lambda ? "lvti.lambda" : "lvti.method.ref");
return HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR).descriptionAndTooltip(message).range(typeElement);
}
@@ -551,7 +552,7 @@ public final class HighlightUtil {
}
PsiType lType = variable.getType();
if (PsiTypes.nullType().equals(lType) &&
if (PsiTypes.nullType().equals(lType) &&
ExpressionUtils.nonStructuralChildren(initializer).allMatch(ExpressionUtils::isNullLiteral)) {
HighlightInfo.Builder info =
HighlightInfo.newHighlightInfo(HighlightInfoType.ERROR).descriptionAndTooltip(JavaErrorBundle.message("lvti.null"))
@@ -2104,7 +2105,7 @@ public final class HighlightUtil {
}
}
if (qualifier != null && aClass.isInterface() && expr instanceof PsiSuperExpression &&
if (qualifier != null && aClass.isInterface() && expr instanceof PsiSuperExpression &&
JavaFeature.EXTENSION_METHODS.isSufficient(languageLevel)) {
//15.12.1 for method invocation expressions; 15.13 for method references
//If TypeName denotes an interface, I, then let T be the type declaration immediately enclosing the method reference expression.
@@ -2803,7 +2804,7 @@ public final class HighlightUtil {
field.getContainingClass() == PsiTreeUtil.getParentOfType(expression, PsiClass.class, true)) {
return null;
}
resolvedName =
resolvedName =
PsiFormatUtil.formatVariable(field, PsiFormatUtilBase.SHOW_CONTAINING_CLASS | PsiFormatUtilBase.SHOW_NAME, PsiSubstitutor.EMPTY);
referencedClass = field.getContainingClass();
}
@@ -3276,7 +3277,7 @@ public final class HighlightUtil {
boolean leftAnonymous = PsiUtil.resolveClassInClassTypeOnly(lType) instanceof PsiAnonymousClass;
String styledReason = reason.isEmpty() ? "" :
String.format("<table><tr><td style=''padding-top: 10px; padding-left: 4px;''>%s</td></tr></table>", reason);
IncompatibleTypesTooltipComposer tooltipComposer = (lTypeString, lTypeArguments, rTypeString, rTypeArguments) ->
IncompatibleTypesTooltipComposer tooltipComposer = (lTypeString, lTypeArguments, rTypeString, rTypeArguments) ->
JavaErrorBundle.message("incompatible.types.html.tooltip",
lTypeString, lTypeArguments,
rTypeString, rTypeArguments,

3
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/advLVTI/SimpleAvailability.java
View File

@@ -16,7 +16,7 @@ class Main {
var zz = <error descr="Variable 'zz' might not have been initialized">zz</error>;
zz.<error descr="Cannot resolve method 'hashCode()'">hashCode</error>();
}
static int baz(Object o) {return 42;}
private static void localVariableType() {
@@ -35,6 +35,7 @@ class Main {
int el = e.compareTo("");
<error descr="Cannot infer type: lambda expression requires an explicit target type">var</error> f = () -> "hello";
<error descr="Cannot infer type: lambda expression requires an explicit target type">var</error> fp = (() -> "hello");
<error descr="Cannot infer type: method reference requires an explicit target type">var</error> m = Main::localVariableDeclaration;
<error descr="Cannot infer type: variable initializer is 'null'">var</error> g = null;
var runnable = true ? <error descr="Lambda expression not expected here">() -> {}</error> : <error descr="Lambda expression not expected here">() -> {}</error>;