MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Prevent insertion of redundant import statement in the original file of moved element

Browse Source 
It happens if we move global variable that references itself, e.g.
VAR = lambda: VAR. Redundant import was optimized out at the end of
refactoring though.
This commit is contained in:
Mikhail Golubev
2015-03-25 21:10:47 +03:00
parent a04bede589
commit 3d193d5519
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/refactoring/move/PyMoveModuleMembersProcessor.java
+2 -1
View File
@@ -245,7 +245,8 @@ public class PyMoveModuleMembersProcessor extends BaseRefactoringProcessor {
PyClassRefactoringUtil.updateImportOfElement(importStmt, newElement);
}
final PsiFile usageFile = usage.getContainingFile();
if (usageFile == oldElement.getContainingFile() && !PsiTreeUtil.isAncestor(oldElement, usage, false)) {
final PsiElement oldElementBody = PyMoveModuleMembersHelper.expandNamedElementBody(oldElement);
if (usageFile == oldElement.getContainingFile() && !PsiTreeUtil.isAncestor(oldElementBody, usage, false)) {
PyClassRefactoringUtil.insertImport(oldElement, newElement);
}
if (resolvesToLocalStarImport(usage)) {