MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

don't offer the callee of a call as a smart introduce variant (PY-1026)

Browse Source
This commit is contained in:
Dmitry Jemerov
2010-05-31 20:22:51 +04:00
parent cd4c10b43f
commit 3ca71669d6
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/refactoring/introduce/IntroduceHandler.java
+9 -1
View File
@@ -140,7 +140,7 @@ abstract public class IntroduceHandler implements RefactoringActionHandler {
if (elementAtCaret instanceof PyStatement) {
break;
}
if (elementAtCaret instanceof PyExpression) {
if (elementAtCaret instanceof PyExpression && isValidIntroduceVariant(elementAtCaret)) {
expressions.add((PyExpression)elementAtCaret);
}
elementAtCaret = elementAtCaret.getParent();
@@ -165,6 +165,14 @@ abstract public class IntroduceHandler implements RefactoringActionHandler {
return false;
}
private static boolean isValidIntroduceVariant(PsiElement element) {
final PyCallExpression call = PsiTreeUtil.getParentOfType(element, PyCallExpression.class);
if (call != null && PsiTreeUtil.isAncestor(call.getCallee(), element, false)) {
return false;
}
return true;
}
private void performActionOnElement(Editor editor,
PsiElement element,
String name,