MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup (warnings; formatting)

Browse Source 
GitOrigin-RevId: b27408718bde26b869390bd9ebdf645f88a391ca
This commit is contained in:
Roman Shevchenko
2019-06-13 03:24:55 +03:00
committed by intellij-monorepo-bot
parent fd765ccc09
commit 3bea463cc1
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/core-impl/src/com/intellij/ide/plugins/PluginManagerCore.java
+7 -3
View File
@@ -91,6 +91,8 @@ public class PluginManagerCore {
@SuppressWarnings("StaticNonFinalField")
public static volatile boolean isUnitTestMode = Boolean.getBoolean("idea.is.unit.test");
@SuppressWarnings("FieldAccessedSynchronizedAndUnsynchronized")
private static boolean ourUnitTestWithBundledPlugins = Boolean.getBoolean("idea.run.tests.with.bundled.plugins");
private static final String PLUGIN_IS_DISABLED_REASON = "Plugin is disabled";
@@ -464,10 +466,12 @@ public class PluginManagerCore {
return null;
}
//if a plugin does not include any module dependency tags in its plugin.xml,it's assumed to be a legacy plugin and is loaded only in IntelliJ IDEA, so it may use classes from Java plugin
// If a plugin does not include any module dependency tags in its plugin.xml, it's assumed to be a legacy plugin
// and is loaded only in IntelliJ IDEA, so it may use classes from Java plugin.
boolean isLegacyPlugin = !hasModuleDependencies(descriptor);
//many custom plugins use classes from Java plugin and don't declare a dependency on the Java module (although they declare dependency on some other platform modules).
//this is definitely a misconfiguration but let's temprary add the Java plugin to their dependencies to avoid breaking compatibility
// Many custom plugins use classes from Java plugin and don't declare a dependency on the Java module (although they declare dependency
// on some other platform modules). This is definitely a misconfiguration but lets temporary add the Java plugin to their dependencies
// to avoid breaking compatibility.
boolean isCustomPlugin = !descriptor.isBundled();
return isLegacyPlugin || isCustomPlugin ? ourModulesToContainingPlugins.get("com.intellij.modules.java") : null;
}