MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IG: don't try to make method in library final (IDEA-177140)

Browse Source
This commit is contained in:
Bas Leijdekkers
2017-08-24 15:02:44 +02:00
parent 19f65d381f
commit 3bc439b430
1 changed files with 18 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/src/com/siyeh/ig/initialization/OverridableMethodCallDuringObjectConstructionInspection.java
+18 -5
View File
@@ -20,6 +20,7 @@ import com.intellij.codeInspection.ProblemDescriptor;
import com.intellij.openapi.application.WriteAction;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.util.SmartList;
import com.siyeh.InspectionGadgetsBundle;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.fixes.MakeClassFinalFix;
@@ -27,21 +28,30 @@ import com.siyeh.ig.psiutils.ClassUtils;
import com.siyeh.ig.psiutils.MethodUtils;
import org.jetbrains.annotations.NotNull;
import java.util.List;
public class OverridableMethodCallDuringObjectConstructionInspection extends OverridableMethodCallDuringObjectConstructionInspectionBase {
@Override
protected boolean buildQuickFixesOnlyForOnTheFlyErrors() {
return true;
}
@Override
@NotNull
protected InspectionGadgetsFix[] buildFixes(Object... infos) {
final PsiMethodCallExpression methodCallExpression = (PsiMethodCallExpression)infos[0];
final PsiClass callClass = ClassUtils.getContainingClass(methodCallExpression);
final PsiMethod method = methodCallExpression.resolveMethod();
if (method == null || MethodUtils.isOverriddenInHierarchy(method, callClass)) {
if (method == null || callClass == null || MethodUtils.isOverriddenInHierarchy(method, callClass)) {
return InspectionGadgetsFix.EMPTY_ARRAY;
}
return new InspectionGadgetsFix[]{
new MakeClassFinalFix(callClass),
new MakeMethodFinalFix(method.getName())
};
final List<InspectionGadgetsFix> fixes = new SmartList<>();
fixes.add(new MakeClassFinalFix(callClass));
if (!(method instanceof PsiCompiledElement)) {
fixes.add(new MakeMethodFinalFix(method.getName()));
}
return fixes.toArray(InspectionGadgetsFix.EMPTY_ARRAY);
}
private static class MakeMethodFinalFix extends InspectionGadgetsFix {
@@ -74,6 +84,9 @@ public class OverridableMethodCallDuringObjectConstructionInspection extends Ove
return;
}
WriteAction.run(() -> method.getModifierList().setModifierProperty(PsiModifier.FINAL, true));
if (method.getContainingFile() != methodExpression.getContainingFile()) {
method.navigate(true);
}
}
@Override