IDEA-217183 DevKit: PluginXmlDomInspection should not request icon from implementation-detail plugins

GitOrigin-RevId: 3d6ccfc4c3a54ac485e73373e0d7252e09b5b875

plugins/devkit/devkit-core/src/inspections/PluginXmlDomInspection.java

@@ -373,6 +373,7 @@ public class PluginXmlDomInspection extends BasicDomElementsInspection<IdeaPlugi
   private static void checkPluginIcon(IdeaPlugin ideaPlugin, DomElementAnnotationHolder holder, Module module) {
     if (!hasRealPluginId(ideaPlugin)) return;
     if (!isUnderProductionSources(ideaPlugin, module)) return;
+    if (Boolean.TRUE == ideaPlugin.getImplementationDetail().getValue()) return;
 
     Collection<VirtualFile> pluginIconFiles =
       FilenameIndex.getVirtualFilesByName(module.getProject(), PLUGIN_ICON_SVG_FILENAME, GlobalSearchScope.moduleScope(module));

plugins/devkit/devkit-java-tests/testData/codeInsight/pluginIconNotNecessaryForImplementationDetail.xml

@@ -0,0 +1,6 @@
+<idea-plugin implementation-detail="true">
+  <id>plugin.with.icon</id>
+  <name>Icon not necessary</name>
+  <vendor>Icons Inc.</vendor>
+  <version>1.0</version>
+</idea-plugin>

plugins/devkit/devkit-java-tests/testSrc/org/jetbrains/idea/devkit/codeInsight/PluginXmlFunctionalTest.groovy

@@ -659,6 +659,10 @@ public class MyErrorHandler extends ErrorReportSubmitter {}
     myFixture.testHighlighting(true, true, true, "pluginIconFound.xml")
   }
 
+  void testPluginIconNotNecessaryForImplementationDetail() {
+    myFixture.testHighlighting(true, true, true, "pluginIconNotNecessaryForImplementationDetail.xml")
+  }
+
   void testPluginIconNotFound() {
     myFixture.testHighlighting(true, true, true, "pluginIconNotFound.xml")
   }