MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IG: try to make inspection non-quadratic

Browse Source
This commit is contained in:
Bas Leijdekkers
2016-10-20 20:07:53 +02:00
parent 1a7e552fa6
commit 3bb1d1c10f
1 changed files with 15 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/naming/LambdaUnfriendlyMethodOverloadInspectionBase.java
+15 -2
View File
@@ -15,6 +15,7 @@
*/
package com.siyeh.ig.naming;
import com.intellij.openapi.util.Key;
import com.intellij.psi.*;
import com.intellij.psi.util.PsiSuperMethodUtil;
import com.siyeh.InspectionGadgetsBundle;
@@ -52,9 +53,14 @@ public class LambdaUnfriendlyMethodOverloadInspectionBase extends BaseInspection
private static class LambdaUnfriendlyMethodOverloadVisitor extends BaseInspectionVisitor {
private static final Key<Boolean> SKIP_MARKER = new Key<>("skip marker for lambda unfriendly method overload inspection");
@Override
public void visitMethod(PsiMethod method) {
super.visitMethod(method);
if (method.getUserData(SKIP_MARKER) == Boolean.TRUE) {
return;
}
final PsiParameterList parameterList = method.getParameterList();
final int parametersCount = parameterList.getParametersCount();
if (parametersCount == 0) {
@@ -77,6 +83,7 @@ public class LambdaUnfriendlyMethodOverloadInspectionBase extends BaseInspection
return;
}
final String name = method.getName();
boolean problemFound = false;
for (PsiMethod sameNameMethod : containingClass.findMethodsByName(name, true)) {
if (method.equals(sameNameMethod) || PsiSuperMethodUtil.isSuperMethod(method, sameNameMethod)) {
continue;
@@ -95,10 +102,16 @@ public class LambdaUnfriendlyMethodOverloadInspectionBase extends BaseInspection
}
if (areSameShapeFunctionalTypes(functionalType, otherFunctionalType)) {
registerMethodError(method, method);
return;
problemFound = true;
if (containingClass.equals(sameNameMethod.getContainingClass())) {
registerMethodError(sameNameMethod, sameNameMethod);
sameNameMethod.putUserData(SKIP_MARKER, Boolean.TRUE);
}
}
}
if (problemFound) {
registerMethodError(method, method);
}
}
private static boolean areSameShapeFunctionalTypes(PsiType one, PsiType two) {