MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

RegExp: fix false positive on class intersection (IJPL-102098)

Browse Source 
in "Regular expression can be simplified" inspection

GitOrigin-RevId: 91eafa57c5e1a1e5df8fd1f8e3b0fb1644891e04
This commit is contained in:
Bas Leijdekkers
2025-04-12 16:28:13 +00:00
committed by intellij-monorepo-bot
parent edaef30179
commit 3a8dccfbc7
2 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
RegExpSupport/src/org/intellij/lang/regexp/inspection/RegExpSimplifiableInspection.java
+2 -2
View File
@@ -1,4 +1,4 @@
// Copyright 2000-2023 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package org.intellij.lang.regexp.inspection;
import com.intellij.codeInspection.*;
@@ -62,7 +62,7 @@ public class RegExpSimplifiableInspection extends LocalInspectionTool {
if (elements.length == 1) {
final RegExpClassElement element = elements[0];
if (element instanceof RegExpPosixBracketExpression) return;
if (!(element instanceof RegExpCharRange)) {
if (!(element instanceof RegExpCharRange) && !(element instanceof RegExpIntersection)) {
if (!(element instanceof RegExpChar) || !"{}().*+?|$".contains(element.getText())) {
// [a] -> a
registerProblem(regExpClass, element.getUnescapedText());
RegExpSupport/test/org/intellij/lang/regexp/inspection/RegExpSimplifiableInspectionTest.java
+6 -1
View File
@@ -1,4 +1,4 @@
// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
// Copyright 2000-2025 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package org.intellij.lang.regexp.inspection;
import com.intellij.codeInspection.CommonQuickFixBundle;
@@ -37,6 +37,11 @@ public class RegExpSimplifiableInspectionTest extends RegExpInspectionTestCase {
highlightTest("[0-9abc]"); // no warn; replacing with \d is not equivalent in Unicode context
}
public void testIntersection() {
highlightTest("^[\\p{ASCII}&&[^@]]+@[\\p{ASCII}&&[^@]]+$");
highlightTest("[\\W&&\\S]");
}
public void testSingleElementClass() {
doTest("[a]", "a");
}