MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[git] DRY (define constants), protect against NPE (flip equals)

Browse Source
This commit is contained in:
Kirill Likhodedov
2013-03-25 15:35:00 +04:00
parent 46940b6c39
commit 39efcb5ab0
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/git4idea/src/git4idea/GitVcs.java
+6 -4
View File
@@ -460,17 +460,19 @@ public class GitVcs extends AbstractVcs<CommittedChangeList> {
myVersion = GitVersion.identifyVersion(executable);
if (! myVersion.isSupported()) {
log.info("Unsupported Git version: " + myVersion);
String message = String.format("The <a href='settings'>configured</a> version of Git is not supported: %s.<br/> " +
"The minimal supported version is %s. Please <a href='update'>update</a>.",
final String SETTINGS_LINK = "settings";
final String UPDATE_LINK = "update";
String message = String.format("The <a href='" + SETTINGS_LINK + "'>configured</a> version of Git is not supported: %s.<br/> " +
"The minimal supported version is %s. Please <a href='" + UPDATE_LINK + "'>update</a>.",
myVersion, GitVersion.MIN);
IMPORTANT_ERROR_NOTIFICATION.createNotification("Unsupported Git version", message, NotificationType.ERROR,
new NotificationListener.Adapter() {
@Override
protected void hyperlinkActivated(@NotNull Notification notification, @NotNull HyperlinkEvent e) {
if (e.getDescription().equals("settings")) {
if (SETTINGS_LINK.equals(e.getDescription())) {
ShowSettingsUtil.getInstance().showSettingsDialog(myProject, getConfigurable().getDisplayName());
}
else if (e.getDescription().equals("update")) {
else if (UPDATE_LINK.equals(e.getDescription())) {
BrowserUtil.browse("http://git-scm.com");
}
}