MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-05 01:50:56 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-229683 Replacement IntStream.range.mapToObj with Arrays.stream is wrong when array elements are written.

Browse Source 
GitOrigin-RevId: c386abf6f7716ec75b49ca5e6b0a5676c29b1744
This commit is contained in:
Tagir Valeev
2019-12-30 23:22:08 +07:00
committed by intellij-monorepo-bot
parent 9fb8d24627
commit 3718ed889f
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/java-impl/src/com/intellij/codeInspection/SimplifyStreamApiCallChainsInspection.java
View File

@@ -1220,8 +1220,8 @@ public class SimplifyStreamApiCallChainsInspection extends AbstractBaseJavaLocal
if (body == null) return null;
Collection<PsiReference> refs = ReferencesSearch.search(indexParameter, new LocalSearchScope(body)).findAll();
if (!refs.isEmpty() &&
refs.stream()
.allMatch(ref -> limitedContainer.myContainer.extractGetExpressionFromIndex(tryCast(ref, PsiExpression.class)) != null)) {
refs.stream().map(ref -> limitedContainer.myContainer.extractGetExpressionFromIndex(tryCast(ref, PsiExpression.class)))
.allMatch(expression -> expression != null && !PsiUtil.isAccessedForWriting(expression))) {
return limitedContainer;
}
}

11
java/java-tests/testData/inspection/streamApiCallChains/beforeRangeWrite.java Normal file
View File

@@ -0,0 +1,11 @@
// "Replace IntStream.range().mapToObj() with Arrays.stream(strs)" "false"
import java.util.stream.IntStream;
import java.util.stream.Collectors;
class Test {
void test() {
String [] strs = new String[239];
List<String> collect = IntStream.range(0, strs.length).
<Runnable><caret>mapToObj(idx -> () -> strs[idx] = strs[idx].toUpperCase()).collect(Collectors.toList());
}
}