MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[extract method] fix the flaky parameter name suggestion

Browse Source 
GitOrigin-RevId: 1f278179d51e1dac3cb2992a3ec85c98ac208b31
This commit is contained in:
Alexandr Suhinin
2024-05-10 11:27:40 +00:00
committed by intellij-monorepo-bot
parent 91314059d0
commit 360db06c21
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/refactoring/extractMethod/ParametersFolder.java
+5 -2
View File
@@ -179,8 +179,11 @@ public class ParametersFolder {
List<PsiExpression> expressions = null;
Boolean arrayAccess = null;
for (PsiReference reference : ReferencesSearch.search(var, scope)) {
PsiElement expression = reference.getElement();
List<PsiElement> refExpressions = ReferencesSearch.search(var, scope).findAll().stream()
.map(ref -> ref.getElement())
.sorted(Comparator.comparingInt(element -> element.getTextRange().getStartOffset()))
.toList();
for (PsiElement expression : refExpressions) {
if (expressions == null) {
expressions = new ArrayList<>();
while (expression instanceof PsiExpression) {
java/java-tests/testData/refactoring/extractMethod/FoldedWithNestedExpressions_after.java
+2 -2
View File
@@ -4,8 +4,8 @@ class Test {
System.out.println(s1);
}
private String newMethod(String s2, String s11) {
System.out.println(s2);
private String newMethod(String x, String s11) {
System.out.println(x);
return s11;
}
}