MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-02-04 23:39:07 +07:00
Code Issues Packages Projects Releases Wiki Activity

add knownIssue sections for top issues

Browse Source 
GitOrigin-RevId: 2fe372a51180652774c040abd46897e5c85c7666
This commit is contained in:
Gregory.Shrago
2023-07-27 21:04:01 +04:00
committed by intellij-monorepo-bot
parent 3b2227e2e7
commit 34f80da90c
8 changed files with 41 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
platform/core-impl/src/com/intellij/psi/impl/PsiDocumentManagerBase.java
View File

@@ -729,7 +729,9 @@ public abstract class PsiDocumentManagerBase extends PsiDocumentManager implemen
@Override
public boolean hasEventSystemEnabledUncommittedDocuments() {
return ContainerUtil.exists(myUncommittedDocuments, this::isEventSystemEnabled);
try (AccessToken ignore = SlowOperations.knownIssue("IDEA-319884, EA-831652, IDEA-301732, EA-659436, IDEA-307614, EA-773260")) {
return ContainerUtil.exists(myUncommittedDocuments, this::isEventSystemEnabled);
}
}
private void beforeCommitHandler() {

13
platform/lang-impl/src/com/intellij/codeInsight/folding/impl/UpdateFoldRegionsOperation.java
View File

@@ -3,6 +3,7 @@ package com.intellij.codeInsight.folding.impl;
import com.intellij.lang.folding.FoldingDescriptor;
import com.intellij.lang.injection.InjectedLanguageManager;
import com.intellij.openapi.application.AccessToken;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.editor.Editor;
import com.intellij.openapi.editor.FoldRegion;
@@ -133,11 +134,13 @@ final class UpdateFoldRegionsOperation implements Runnable {
descriptor.isNonExpandable());
if (region == null) continue;
PsiElement psi = descriptor.getElement().getPsi();
if (psi == null || !psi.isValid() || !myFile.isValid()) {
region.dispose();
continue;
PsiElement psi;
try (AccessToken ignore = SlowOperations.knownIssue("IDEA-326651, EA-831712")) {
psi = descriptor.getElement().getPsi();
if (psi == null || !psi.isValid() || !myFile.isValid()) {
region.dispose();
continue;
}
}
region.setGutterMarkEnabledForSingleLine(descriptor.isGutterMarkEnabledForSingleLine());

5
platform/lang-impl/src/com/intellij/refactoring/move/MoveHandler.java
View File

@@ -7,6 +7,7 @@ import com.intellij.lang.Language;
import com.intellij.openapi.actionSystem.CommonDataKeys;
import com.intellij.openapi.actionSystem.DataContext;
import com.intellij.openapi.actionSystem.LangDataKeys;
import com.intellij.openapi.application.AccessToken;
import com.intellij.openapi.editor.Editor;
import com.intellij.openapi.editor.ScrollType;
import com.intellij.openapi.project.DumbService;
@@ -162,7 +163,9 @@ public class MoveHandler implements RefactoringActionHandler {
* target container can be null => means that container is not determined yet and must be specified by the user
*/
public static boolean canMove(PsiElement @NotNull [] elements, PsiElement targetContainer) {
return findDelegate(elements, targetContainer, null) != null;
try (AccessToken ignore = SlowOperations.knownIssue("IDEA-326650, EA-659473")) {
return findDelegate(elements, targetContainer, null) != null;
}
}
@Nullable

6
platform/lvcs-impl/src/com/intellij/history/integration/IdeaGateway.java
View File

@@ -9,6 +9,7 @@ import com.intellij.history.core.tree.Entry;
import com.intellij.history.core.tree.FileEntry;
import com.intellij.history.core.tree.RootEntry;
import com.intellij.ide.scratch.ScratchFileService;
import com.intellij.openapi.application.AccessToken;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.editor.Document;
import com.intellij.openapi.fileEditor.FileDocumentManager;
@@ -29,6 +30,7 @@ import com.intellij.openapi.vfs.newvfs.ManagingFS;
import com.intellij.openapi.vfs.newvfs.NewVirtualFile;
import com.intellij.openapi.vfs.newvfs.events.VFileEvent;
import com.intellij.openapi.vfs.newvfs.impl.VirtualFileSystemEntry;
import com.intellij.util.SlowOperations;
import com.intellij.util.SmartList;
import com.intellij.util.containers.ContainerUtil;
import com.intellij.util.io.URLUtil;
@@ -400,7 +402,9 @@ public class IdeaGateway {
}
private boolean shouldRegisterDocument(@Nullable VirtualFile f) {
return f != null && f.isValid() && areContentChangesVersioned(f);
try (AccessToken ignore = SlowOperations.knownIssue("IDEA-307668, EA-821075")) {
return f != null && f.isValid() && areContentChangesVersioned(f);
}
}
private void registerDocumentContents(@NotNull LocalHistoryFacade vcs, @NotNull VirtualFile f, Document d) {

6
platform/platform-impl/src/com/intellij/openapi/editor/impl/TrailingSpacesStripper.java
View File

@@ -5,6 +5,7 @@ import com.intellij.ide.DataManager;
import com.intellij.injected.editor.DocumentWindow;
import com.intellij.openapi.actionSystem.CommonDataKeys;
import com.intellij.openapi.actionSystem.DataContext;
import com.intellij.openapi.application.AccessToken;
import com.intellij.openapi.application.Application;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.client.ClientKind;
@@ -23,6 +24,7 @@ import com.intellij.openapi.util.ShutDownTracker;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.openapi.wm.IdeFocusManager;
import com.intellij.util.ArrayUtilRt;
import com.intellij.util.SlowOperations;
import com.intellij.util.text.CharArrayUtil;
import com.intellij.util.ui.UIUtil;
import org.jetbrains.annotations.NotNull;
@@ -256,7 +258,9 @@ public final class TrailingSpacesStripper implements FileDocumentManagerListener
}
VirtualFile file = FileDocumentManager.getInstance().getFile(document);
if (file != null) {
return ProjectUtil.guessProjectForFile(file);
try (AccessToken ignore = SlowOperations.knownIssue("IDEA-323372, EA-857522")) {
return ProjectUtil.guessProjectForFile(file);
}
}
return null;
}

5
platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/FileEditorProviderManagerImpl.kt
View File

@@ -21,6 +21,7 @@ import com.intellij.openapi.fileTypes.FileTypeRegistry
import com.intellij.openapi.project.DumbService
import com.intellij.openapi.project.Project
import com.intellij.openapi.vfs.VirtualFile
import com.intellij.util.SlowOperations
import kotlinx.coroutines.*
import kotlinx.serialization.Serializable
import org.jetbrains.annotations.TestOnly
@@ -63,7 +64,9 @@ class FileEditorProviderManagerImpl : FileEditorProviderManager,
}
if (ApplicationManager.getApplication().runReadAction<Boolean, RuntimeException> {
checkProvider(project = project, file = file, provider = provider, suppressors = suppressors)
SlowOperations.knownIssue("IDEA-307300, EA-816241").use {
checkProvider(project = project, file = file, provider = provider, suppressors = suppressors)
}
}) {
sharedProviders.add(provider)
hideDefaultEditor = hideDefaultEditor or (provider.policy == FileEditorPolicy.HIDE_DEFAULT_EDITOR)

8
platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ChangeListManagerImpl.java
View File

@@ -6,6 +6,7 @@ import com.intellij.concurrency.SensitiveProgressWrapper;
import com.intellij.ide.highlighter.WorkspaceFileType;
import com.intellij.internal.statistic.StructuredIdeActivity;
import com.intellij.openapi.Disposable;
import com.intellij.openapi.application.AccessToken;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.application.ModalityState;
import com.intellij.openapi.application.ReadAction;
@@ -1170,8 +1171,11 @@ public final class ChangeListManagerImpl extends ChangeListManagerEx implements
@Override
public boolean isUnversioned(@NotNull VirtualFile file) {
VcsRoot vcsRoot = ProjectLevelVcsManager.getInstance(myProject).getVcsRootObjectFor(file);
if (vcsRoot == null) return false;
VcsRoot vcsRoot;
try (AccessToken ignore = SlowOperations.knownIssue("IDEA-322445, EA-857508")) {
vcsRoot = ProjectLevelVcsManager.getInstance(myProject).getVcsRootObjectFor(file);
if (vcsRoot == null) return false;
}
return ReadAction.compute(() -> {
synchronized (myDataLock) {

9
platform/vcs-impl/src/com/intellij/openapi/vcs/changes/ui/ChangesBrowserFileNode.java
View File

@@ -2,10 +2,12 @@
package com.intellij.openapi.vcs.changes.ui;
import com.intellij.openapi.application.AccessToken;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.vcs.FileStatus;
import com.intellij.openapi.vcs.changes.ChangeListManager;
import com.intellij.openapi.vfs.VirtualFile;
import com.intellij.util.SlowOperations;
import com.intellij.vcsUtil.VcsUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
@@ -37,9 +39,10 @@ public class ChangesBrowserFileNode extends ChangesBrowserNode<VirtualFile> impl
@Override
public void render(@NotNull final ChangesBrowserNodeRenderer renderer, final boolean selected, final boolean expanded, final boolean hasFocus) {
final VirtualFile file = getUserObject();
FileStatus fileStatus = getFileStatus();
renderer.appendFileName(file, file.getName(), fileStatus.getColor());
try (AccessToken ignore = SlowOperations.knownIssue("IDEA-322065, EA-857522")) {
FileStatus fileStatus = getFileStatus();
renderer.appendFileName(file, file.getName(), fileStatus.getColor());
}
if (renderer.isShowFlatten()) {
if (file.isValid()) {