[java] refactoring: get rid of access to protected members in production not from subclasses in test code (IJPL-205216)

This is needed to avoid IllegalAccessError if tests are loaded by a different classloader and to allow enabling 'Suspicious Package-Private Access' for tests as well.

Separate test-only public accessor methods for are added.

GitOrigin-RevId: 36fde4112e67c9aab42097aa70ffbfbab1ec4ceb

java/debugger/impl/src/com/intellij/debugger/engine/SuspendManagerImpl.java

@@ -19,6 +19,7 @@ import org.intellij.lang.annotations.MagicConstant;
 import org.jetbrains.annotations.ApiStatus;
 import org.jetbrains.annotations.NotNull;
 import org.jetbrains.annotations.Nullable;
+import org.jetbrains.annotations.TestOnly;
 
 import java.util.Deque;
 import java.util.List;
@@ -448,4 +449,9 @@ public class SuspendManagerImpl implements SuspendManager {
 
     return thread == resumeOneSteppingIn.getThreadReference();
   }
+  
+  @TestOnly
+  public void addExplicitlyResumedThread(@NotNull ThreadReferenceProxyImpl thread) {
+    myExplicitlyResumedThreads.add(thread);
+  }
 }

java/java-impl/src/com/intellij/codeInsight/generation/ui/AbstractGenerateEqualsWizard.java

@@ -9,15 +9,14 @@ import com.intellij.openapi.project.Project;
 import com.intellij.psi.PsiElement;
 import com.intellij.refactoring.classMembers.MemberInfoBase;
 import com.intellij.refactoring.ui.AbstractMemberSelectionPanel;
+import org.jetbrains.annotations.TestOnly;
 
 import javax.swing.*;
 import javax.swing.event.TableModelEvent;
 import javax.swing.event.TableModelListener;
 import java.awt.*;
-import java.util.Collection;
-import java.util.HashMap;
+import java.util.*;
 import java.util.List;
-import java.util.Map;
 
 /**
  * Nikolay.Tropin
@@ -161,6 +160,11 @@ public abstract class AbstractGenerateEqualsWizard <C extends PsiElement, M exte
     return true;
   }
 
+  @TestOnly
+  public Set<Map.Entry<M,I>> getFieldsToNonNull() {
+    return new LinkedHashSet<>(myFieldsToNonNull.entrySet());
+  }
+
   @Override
   public JComponent getPreferredFocusedComponent() {
     final Component stepComponent = getCurrentStepComponent();

java/java-tests/testSrc/com/intellij/codeInsight/daemon/quickFix/CreateFilePathFixTest.kt

@@ -127,7 +127,7 @@ class CreateFilePathFixTest : CreateFileQuickFixTestCase() {
       assertEquals(expectedFileName, fileReference.fileNameToCreate)
       val intention = fileReference.quickFixes!![0]
 
-      val options = (intention as AbstractCreateFileFix).myDirectories
+      val options = (intention as AbstractCreateFileFix).directories
 
       assertEquals(expectedOptions.size, options.size)
 

java/java-tests/testSrc/com/intellij/codeInsight/generation/ui/GenerateEqualsWizardTest.java

@@ -25,7 +25,7 @@ public class GenerateEqualsWizardTest extends LightJavaCodeInsightFixtureTestCas
     GenerateEqualsWizard wizard = new GenerateEqualsWizard(getProject(), aClass, true, true);
     NonBlockingReadActionImpl.waitForAsyncTaskCompletion();
     try {
-      Set<Map.Entry<PsiMember, MemberInfo>> entries = wizard.myFieldsToNonNull.entrySet();
+      Set<Map.Entry<PsiMember, MemberInfo>> entries = wizard.getFieldsToNonNull();
       assertEquals(2, entries.size());
       for (Map.Entry<PsiMember, MemberInfo> entry : entries) {
         PsiMember member = entry.getKey();

java/java-tests/testSrc/com/intellij/ide/todo/ToDoTreeStructureTest.java

@@ -45,7 +45,7 @@ public class ToDoTreeStructureTest extends BaseProjectViewTestCase {
     try {
       all.init();
       //second rebuild, e.g. switching scope in scope based t.o.d.o panel
-      CompletableFuture<?> rebuildCache = all.rebuildCache();
+      CompletableFuture<?> rebuildCache = all.rebuildCacheTestAccessor();
       while (!rebuildCache.isDone()) {
         IdeEventQueue.getInstance().flushQueue();
       }

platform/lang-impl/src/com/intellij/codeInsight/daemon/quickFix/AbstractCreateFileFix.java

@@ -293,6 +293,12 @@ public abstract class AbstractCreateFileFix extends LocalQuickFixAndIntentionAct
       .showInBestPositionFor(editor);
   }
 
+  @TestOnly
+  @ApiStatus.Internal
+  public List<TargetDirectory> getDirectories() {
+    return myDirectories;
+  }
+
   private static @Unmodifiable @NotNull List<TargetDirectoryListItem> getTargetDirectoryListItems(List<? extends TargetDirectory> directories) {
     return ContainerUtil.map(directories, targetDirectory -> {
       PsiDirectory d = targetDirectory.getDirectory();

platform/todo/src/com/intellij/ide/todo/TodoTreeBuilder.java

@@ -37,10 +37,7 @@ import com.intellij.util.concurrency.annotations.RequiresEdt;
 import com.intellij.util.containers.ContainerUtil;
 import com.intellij.util.ui.UIUtil;
 import com.intellij.util.ui.tree.TreeUtil;
-import org.jetbrains.annotations.ApiStatus;
-import org.jetbrains.annotations.NotNull;
-import org.jetbrains.annotations.Nullable;
-import org.jetbrains.annotations.VisibleForTesting;
+import org.jetbrains.annotations.*;
 import org.jetbrains.concurrency.Promise;
 import org.jetbrains.concurrency.Promises;
 
@@ -674,6 +671,12 @@ public abstract class TodoTreeBuilder implements Disposable {
     return myFileTree.isDirectoryEmpty(psiDirectory.getVirtualFile());
   }
 
+  @TestOnly
+  @ApiStatus.Internal
+  public @NotNull CompletableFuture<?> rebuildCacheTestAccessor() {
+    return rebuildCache();
+  }
+  
   private final class MyPsiTreeChangeListener extends PsiTreeChangeAdapter {
 
     @Override