clarify API: introduce StartupActivity.Background

GitOrigin-RevId: abaa567957a7643a649aee8df75bcffd6d89f028

platform/core-api/src/com/intellij/openapi/startup/StartupActivity.java

@@ -26,9 +26,10 @@ public interface StartupActivity {
    * immediately when this happens, so if you need to access other components, you're responsible for doing this in a
    * thread-safe way (e.g. by taking a read action to collect all the state you need).</p>
    */
-  ExtensionPointName<StartupActivity> BACKGROUND_POST_STARTUP_ACTIVITY = ExtensionPointName.create("com.intellij.backgroundPostStartupActivity");
+  ExtensionPointName<StartupActivity.Background> BACKGROUND_POST_STARTUP_ACTIVITY = ExtensionPointName.create("com.intellij.backgroundPostStartupActivity");
 
   void runActivity(@NotNull Project project);
   
   interface DumbAware extends StartupActivity, com.intellij.openapi.project.DumbAware {}
+  interface Background extends StartupActivity {}
 }

platform/external-system-impl/src/com/intellij/openapi/externalSystem/service/ExternalSystemStartupActivity.java

@@ -13,7 +13,7 @@ import com.intellij.openapi.project.Project;
 import com.intellij.openapi.startup.StartupActivity;
 import org.jetbrains.annotations.NotNull;
 
-final class ExternalSystemStartupActivity implements StartupActivity.DumbAware {
+final class ExternalSystemStartupActivity implements StartupActivity.Background {
   @Override
   public void runActivity(@NotNull final Project project) {
     ExternalProjectsManagerImpl.getInstance(project).init();

platform/external-system-impl/src/com/intellij/openapi/externalSystem/service/project/manage/ReprocessContentRootDataActivity.kt

@@ -12,7 +12,7 @@ import com.intellij.openapi.module.ModuleManager
 import com.intellij.openapi.project.Project
 import com.intellij.openapi.startup.StartupActivity
 
-class ReprocessContentRootDataActivity : StartupActivity.DumbAware {
+class ReprocessContentRootDataActivity : StartupActivity.Background {
   private val LOG = Logger.getInstance(ReprocessContentRootDataActivity::class.java)
 
   override fun runActivity(project: Project) {

platform/platform-impl/src/com/intellij/diagnostic/MemorySizeConfigurator.kt

@@ -13,7 +13,7 @@ import java.lang.management.ManagementFactory
 /**
  * @author yole
  */
-class MemorySizeConfigurator : StartupActivity {
+class MemorySizeConfigurator : StartupActivity.Background {
   override fun runActivity(project: Project) {
     if (ApplicationManager.getApplication().isUnitTestMode) return
 

platform/platform-impl/src/com/intellij/diagnostic/WindowsDefenderCheckerActivity.kt

@@ -17,7 +17,7 @@ import com.intellij.openapi.ui.Messages
 import com.intellij.util.ui.UIUtil
 import java.nio.file.Path
 
-class WindowsDefenderCheckerActivity : StartupActivity {
+class WindowsDefenderCheckerActivity : StartupActivity.Background {
   override fun runActivity(project: Project) {
     val app = ApplicationManager.getApplication()
     if (app.isUnitTestMode) return

platform/platform-impl/src/com/intellij/ide/startup/impl/StartupManagerImpl.java

@@ -410,12 +410,12 @@ public class StartupManagerImpl extends StartupManagerEx implements Disposable {
   }
 
   public void scheduleBackgroundPostStartupActivities() {
-    List<StartupActivity> backgroundPostStartupActivities = StartupActivity.BACKGROUND_POST_STARTUP_ACTIVITY.getExtensionList();
+    List<StartupActivity.Background> backgroundPostStartupActivities = StartupActivity.BACKGROUND_POST_STARTUP_ACTIVITY.getExtensionList();
 
     Extensions.getRootArea().getExtensionPoint(StartupActivity.BACKGROUND_POST_STARTUP_ACTIVITY).addExtensionPointListener(
-      new ExtensionPointListener<StartupActivity>() {
+      new ExtensionPointListener<StartupActivity.Background>() {
         @Override
-        public void extensionAdded(@NotNull StartupActivity extension, @NotNull PluginDescriptor pluginDescriptor) {
+        public void extensionAdded(@NotNull StartupActivity.Background extension, @NotNull PluginDescriptor pluginDescriptor) {
           extension.runActivity(myProject);
         }
       }, false, this);

platform/platform-impl/src/com/intellij/openapi/updateSettings/impl/pluginsAdvertisement/PluginsAdvertiserStartupActivity.java

@@ -26,7 +26,7 @@ import java.io.IOException;
 import java.net.UnknownHostException;
 import java.util.*;
 
-final class PluginsAdvertiserStartupActivity implements StartupActivity.DumbAware {
+final class PluginsAdvertiserStartupActivity implements StartupActivity.Background {
   @Override
   public void runActivity(@NotNull Project project) {
     Application app = ApplicationManager.getApplication();

plugins/git4idea/src/git4idea/config/GitSetupProjectConfig.kt

@@ -12,7 +12,7 @@ import git4idea.repo.GitRepositoryManager
 
 const val GC_AUTO = "gc.auto"
 
-class GitSetupProjectConfig: StartupActivity {
+class GitSetupProjectConfig: StartupActivity.Background {
   override fun runActivity(project: Project) {
     ProjectLevelVcsManagerImpl.getInstanceImpl(project).addInitializationRequest(VcsInitObject.AFTER_COMMON) {
       if (ApplicationManager.getApplication().isDispatchThread) {

python/src/com/jetbrains/python/packaging/PyPackagesUpdater.java

@@ -32,7 +32,7 @@ import java.io.IOException;
  * PyPI cache updater
  * User : catherine
  */
-public class PyPackagesUpdater implements StartupActivity {
+public class PyPackagesUpdater implements StartupActivity.Background {
   private static final Logger LOG = Logger.getInstance(PyPackagesUpdater.class);
   private static final long EXPIRATION_TIMEOUT = DateFormatUtil.DAY;
 

python/src/com/jetbrains/python/sdk/PythonSdkUpdater.java

@@ -63,7 +63,7 @@ import java.util.concurrent.Future;
  * @author vlan
  * @author yole
  */
-public class PythonSdkUpdater implements StartupActivity {
+public class PythonSdkUpdater implements StartupActivity.Background {
   private static final Logger LOG = Logger.getInstance("#com.jetbrains.python.sdk.PythonSdkUpdater");
 
   private static final Object ourLock = new Object();