MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2025-12-15 02:59:33 +07:00
Code Issues Packages Projects Releases Wiki Activity

[python] removed duplicated statistics collection group (PY-57292, FUS-2053)

Browse Source 
python.packages.dialog used to duplicate package.management.ui and ui.dialogs

GitOrigin-RevId: ffd186bed9a3748bff170896bbe186069d9d707b
This commit is contained in:
Aleksei Kniazev
2023-05-19 15:48:51 +02:00
committed by intellij-monorepo-bot
parent ae0413924c
commit 3246953b6a
4 changed files with 0 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
python/src/META-INF/python-core-common.xml
View File

@@ -493,7 +493,6 @@
<toolWindowExtractorMode id="Python Packages" mode="mirror"/>
<statistics.counterUsagesCollector implementationClass="com.jetbrains.python.sdk.add.PyAddNewEnvCollector"/>
<statistics.counterUsagesCollector implementationClass="com.jetbrains.python.packaging.statistics.PythonPackagesToolwindowStatisticsCollector"/>
<statistics.counterUsagesCollector implementationClass="com.jetbrains.python.packaging.statistics.PythonPackagesDialogStatisticsCollector"/>
<vcs.envCustomizer implementation="com.jetbrains.python.sdk.PyVirtualEnvVcsCustomizer"/>

22
python/src/com/jetbrains/python/packaging/statistics/PythonPackagesDialogStatisticsCollector.kt
View File

@@ -1,22 +0,0 @@
// Copyright 2000-2022 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license.
package com.jetbrains.python.packaging.statistics
import com.intellij.internal.statistic.eventLog.EventLogGroup
import com.intellij.internal.statistic.service.fus.collectors.CounterUsagesCollector
class PythonPackagesDialogStatisticsCollector : CounterUsagesCollector() {
override fun getGroup(): EventLogGroup = GROUP
companion object {
private val GROUP = EventLogGroup("python.packages.dialog", 1)
@JvmStatic
val packagingOperationEvent = GROUP.registerEvent("packages.changed")
@JvmStatic
val packagingDialogEvent = GROUP.registerEvent("dialog.opened")
@JvmStatic
val packageUninstalledEvent = GROUP.registerEvent("package.uninstalled")
}
}

25
python/src/com/jetbrains/python/packaging/ui/PyInstalledPackagesPanel.java
View File

@@ -19,7 +19,6 @@ import com.intellij.webcore.packaging.*;
import com.jetbrains.python.PyBundle;
import com.jetbrains.python.PySdkBundle;
import com.jetbrains.python.packaging.*;
import com.jetbrains.python.packaging.statistics.PythonPackagesDialogStatisticsCollector;
import com.jetbrains.python.packaging.bridge.PythonPackageManagementServiceBridge;
import com.jetbrains.python.sdk.PySdkExtKt;
import com.jetbrains.python.sdk.PythonSdkUtil;
@@ -258,28 +257,4 @@ public class PyInstalledPackagesPanel extends InstalledPackagesPanel {
protected @NotNull PackagesNotificationPanel createNotificationPanel() {
return new PyPackagesNotificationPanel();
}
@Override
protected @NotNull ManagePackagesDialog createManagePackagesDialog() {
PythonPackagesDialogStatisticsCollector.getPackagingDialogEvent().log(myProject);
return new ManagePackagesDialog(myProject,
myPackageManagementService,
new PackageManagementService.Listener() {
@Override
public void operationStarted(String packageName) {
PythonPackagesDialogStatisticsCollector.getPackagingOperationEvent().log(myProject);
myNotificationArea.hide();
myPackagesTable.setPaintBusy(true);
}
@Override
public void operationFinished(String packageName,
@Nullable PackageManagementService.ErrorDescription errorDescription) {
myNotificationArea.showResult(packageName, errorDescription);
myPackagesTable.clearSelection();
doUpdatePackages(myPackageManagementService);
}
}, createNotificationPanel());
}
}

2
python/src/com/jetbrains/python/packaging/ui/PyPackageManagementService.java
View File

@@ -22,7 +22,6 @@ import com.jetbrains.python.PySdkBundle;
import com.jetbrains.python.packaging.*;
import com.jetbrains.python.packaging.PyPIPackageUtil.PackageDetails;
import com.jetbrains.python.packaging.requirement.PyRequirementRelation;
import com.jetbrains.python.packaging.statistics.PythonPackagesDialogStatisticsCollector;
import com.jetbrains.python.psi.LanguageLevel;
import com.jetbrains.python.sdk.PythonSdkType;
import com.jetbrains.python.sdk.PythonSdkUtil;
@@ -242,7 +241,6 @@ public class PyPackageManagementService extends PackageManagementServiceEx {
@Override
public void uninstallPackages(List<? extends InstalledPackage> installedPackages, @NotNull Listener listener) {
PythonPackagesDialogStatisticsCollector.getPackageUninstalledEvent().log(myProject);
final String packageName = installedPackages.size() == 1 ? installedPackages.get(0).getName() : null;
final PyPackageManagerUI ui = new PyPackageManagerUI(myProject, mySdk, new PyPackageManagerUI.Listener() {
@Override