MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[platform] refactoring: rename ContentModuleDescriptor.getModuleIdString to getModuleNameString for consistency (IJPL-206556)

Browse Source 
We use 'name' attribute in XML for it, and now the module ID is composed of the name and the namespace, so it would be confusing to use 'id' for 'name'.


(cherry picked from commit dafa24422dbde094a63a57fd307721f6848ad26b)

IJ-CR-178875

GitOrigin-RevId: 08280f7e484c97c8e3bc790f1ff22be66ed0e84f
This commit is contained in:
Nikolay Chashnikov
2025-10-20 20:00:08 +00:00
committed by intellij-monorepo-bot
parent 076bfd726f
commit 3237e54a34
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/core-impl/src/com/intellij/ide/plugins/IdeaPluginDescriptorImpl.kt
+1 -1
View File
@@ -622,7 +622,7 @@ class ContentModuleDescriptor(
private val resourceBundleBaseName: String? = raw.resourceBundleBaseName
/** java helper */
fun getModuleIdString(): String = moduleId.name
fun getModuleNameString(): String = moduleId.name
override fun getDescriptorPath(): String = descriptorPath
platform/remote-driver/core/src/com/intellij/driver/impl/Invoker.java
+1 -1
View File
@@ -440,7 +440,7 @@ public class Invoker implements InvokerMBean {
List<ContentModuleDescriptor> modules = IdeaPluginDescriptorImplKt.getContentModules((IdeaPluginDescriptorImpl)plugin);
for (var module : modules) {
if (Objects.equals(moduleId, module.getModuleIdString())) {
if (Objects.equals(moduleId, module.getModuleNameString())) {
return requireNonNull(module.getPluginClassLoader());
}
}
plugins/performanceTesting/core/src/com/jetbrains/performancePlugin/commands/RunServiceInPlugin.java
+1 -1
View File
@@ -33,7 +33,7 @@ public class RunServiceInPlugin extends RunClassInPlugin {
List<ContentModuleDescriptor> modules = IdeaPluginDescriptorImplKt.getContentModules((IdeaPluginDescriptorImpl)plugin);
if (!modules.isEmpty()) {
for (var module : modules) {
if (myClazzName.contains(module.getModuleIdString())) {
if (myClazzName.contains(module.getModuleNameString())) {
loader = module.getClassLoader();
}
}