[java-dfa] DfaCallArguments: do not flush private final variables

GitOrigin-RevId: 054aab1ac093caff699f8710576dd929f66b8674

java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/DfaCallArguments.java

@@ -88,7 +88,8 @@ public final class DfaCallArguments {
         state.flushVariables(v -> v.getQualifier() == qualifier &&
                                   v.getPsiVariable() instanceof PsiMember member &&
                                   member != method &&
-                                  member.hasModifierProperty(PsiModifier.PRIVATE));
+                                  member.hasModifierProperty(PsiModifier.PRIVATE) &&
+                                  !member.hasModifierProperty(PsiModifier.FINAL));
       }
       return;
     }

java/java-tests/testData/inspection/dataFlow/fixture/PrivateMethodDoNotFlushFinalFields.java

@@ -0,0 +1,26 @@
+import org.jetbrains.annotations.Nullable;
+
+abstract class Foo {
+
+  private final Bar bar;
+
+  @Nullable
+  public Object foo() {
+    return bar != null ? bar.a().getObj(getIt(), bar.b()) : null;
+  }
+
+  protected Foo(@Nullable Bar bar) {
+    this.bar = bar;
+  }
+
+  private String getIt() {
+    return "it";
+  }
+}
+
+record Bar(A a, B b) {
+}
+record A() {
+  Object getObj(String s, B b) {return new Object();}
+}
+record B() {}

java/java-tests/testSrc/com/intellij/java/codeInspection/DataFlowInspection21Test.java

@@ -146,6 +146,7 @@ public class DataFlowInspection21Test extends DataFlowInspectionTestCase {
   public void testClassFileGetter() {
     doTest();
   }
+  public void testPrivateMethodDoNotFlushFinalFields() { doTest(); }
   public void testGetterVsDirectAccess() { doTest(); }
   public void testGetterVsDirectAccessRecordOverriddenGetter() { doTest(); }
   public void testGetterVsDirectAccessNonFinal() { doTest(); }