MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

make "'Throwable' printed to 'System.out'" inspection warn in more cases

Browse Source
This commit is contained in:
Bas Leijdekkers
2014-09-12 16:01:57 +02:00
parent 1aabb6b27c
commit 30f03aa7f6
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/maturity/ThrowablePrintedToSystemOutInspection.java
+2 -6
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2000-2013 JetBrains s.r.o.
* Copyright 2000-2014 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -69,11 +69,7 @@ public class ThrowablePrintedToSystemOutInspection extends BaseInspection {
return;
}
final PsiExpression argument = arguments[0];
if (!(argument instanceof PsiReferenceExpression)) {
return;
}
final PsiReferenceExpression referenceExpression = (PsiReferenceExpression)argument;
if (!TypeUtils.expressionHasTypeOrSubtype(referenceExpression, CommonClassNames.JAVA_LANG_THROWABLE)) {
if (!TypeUtils.expressionHasTypeOrSubtype(argument, CommonClassNames.JAVA_LANG_THROWABLE)) {
return;
}
final PsiMethod method = expression.resolveMethod();
plugins/InspectionGadgets/testsrc/com/siyeh/ig/maturity/ThrowablePrintedToSystemOutInspectionTest.java
+4
View File
@@ -30,6 +30,10 @@ public class ThrowablePrintedToSystemOutInspectionTest extends LightInspectionTe
"}\n");
}
public void testEvenSimpler() {
doStatementTest("System.out.println(/*Throwable argument 'new RuntimeException()' to 'System.out.println()' call*/new RuntimeException()/**/);");
}
@Override
protected InspectionProfileEntry getInspection() {
return new ThrowablePrintedToSystemOutInspection();