cleanup anonymous type when asked for variable type

check that effective cast type will help (IDEA-190473)

java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/HighlightUtil.java

@@ -385,7 +385,8 @@ public class HighlightUtil extends HighlightUtilBase {
     }
     if (expression == null) return false;
     PsiType rType = expression.getType();
-    return rType != null && toType != null && TypeConversionUtil.areTypesConvertible(rType, toType);
+    PsiType castType = GenericsUtil.getVariableTypeByExpressionType(toType);
+    return rType != null && toType != null && TypeConversionUtil.areTypesConvertible(rType, toType) && toType.isAssignableFrom(castType);
   }
 
 

java/java-psi-api/src/com/intellij/psi/GenericsUtil.java

@@ -303,6 +303,10 @@ public class GenericsUtil {
   @Contract("null, _ -> null")
   public static PsiType getVariableTypeByExpressionType(@Nullable PsiType type, final boolean openCaptured) {
     if (type == null) return null;
+    PsiClass refClass = PsiUtil.resolveClassInType(type);
+    if (refClass instanceof PsiAnonymousClass) {
+      type = ((PsiAnonymousClass)refClass).getBaseClassType();
+    }
     if (type instanceof PsiCapturedWildcardType) {
       type = ((PsiCapturedWildcardType)type).getUpperBound();
     }

java/java-psi-impl/src/com/intellij/refactoring/util/RefactoringChangeUtil.java

@@ -46,10 +46,6 @@ public class RefactoringChangeUtil {
       }
       return null;
     }
-    PsiClass refClass = PsiUtil.resolveClassInType(type);
-    if (refClass instanceof PsiAnonymousClass) {
-      type = ((PsiAnonymousClass)refClass).getBaseClassType();
-    }
 
     return GenericsUtil.getVariableTypeByExpressionType(type);
   }

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/addTypeCast/beforeNonDenotableLType.java

@@ -0,0 +1,11 @@
+// "Cast to 'java.lang.Object'" "false"
+class Scope<T> {
+    T val;
+    void f() {
+        var y = new Object();
+        var x = new Object() {
+            int a = 12;
+        };
+        x =<caret> val;
+    }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/addTypeCast/beforeNonDenotableVarType.java

@@ -0,0 +1,10 @@
+// "Cast to 'java.lang.Object'" "false"
+class A {
+    void f() {
+        var y = new Object();
+        var x = new Object() {
+            int a = 12;
+        };
+        x = <caret>y;
+    }
+}