MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[devkit] Explicit non-dynamic extension point is not a warning anymore

Browse Source 
GitOrigin-RevId: 6a344299d783d62e5a03419205b9416c654857c2
This commit is contained in:
Yuriy Artamonov
2025-03-03 13:11:10 +00:00
committed by intellij-monorepo-bot
parent d7e4c31308
commit 2f8a6be4ba
4 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/devkit/devkit-core/resources/messages/DevKitBundle.properties
-1
View File
@@ -294,7 +294,6 @@ inspections.plugin.xml.dynamic.plugin.component.usage=Non-dynamic plugin due to
inspections.plugin.xml.dynamic.plugin.component.usage.docs.link.title=Migration Guide
inspections.plugin.xml.dynamic.plugin.option.highlight.usages.ep=Highlight usage of non-dynamic extension points
inspections.plugin.xml.dynamic.plugin.extension.point=Non-dynamic extension point ''{0}''
inspections.plugin.xml.dynamic.plugin.explicit.non.dynamic.extension.point=Explicit non-dynamic extension point ''{0}''
inspections.plugin.xml.dynamic.plugin.id.required.for.group='id' must be specified for <group>
inspections.plugin.xml.dynamic.plugin.usage.of.non.dynamic.extension.point=Usage of non-dynamic extension point ''{0}''
plugins/devkit/devkit-core/src/inspections/PluginXmlDynamicPluginInspection.java
-6
View File
@@ -73,14 +73,8 @@ public final class PluginXmlDynamicPluginInspection extends DevKitPluginXmlInspe
DevKitBundle.message("inspections.plugin.xml.dynamic.plugin.extension.point",
extensionPoint.getEffectiveQualifiedName()));
}
else if (Boolean.FALSE == extensionPoint.getDynamic().getValue()) {
holder.createProblem(extensionPoint,
DevKitBundle.message("inspections.plugin.xml.dynamic.plugin.explicit.non.dynamic.extension.point",
extensionPoint.getEffectiveQualifiedName()));
}
}
private static void highlightGroup(DomElementAnnotationHolder holder, Group group) {
if (!DomUtil.hasXml(group.getId())) {
holder.createProblem(group, DevKitBundle.message("inspections.plugin.xml.dynamic.plugin.id.required.for.group"),
plugins/devkit/devkit-java-tests/testData/codeInsight/pluginXmlDynamicPluginInspection/pluginXmlDynamicPluginInspection-highlighting.xml
+1 -5
View File
@@ -1,20 +1,17 @@
<idea-plugin>
<id>myPlugin</id>
<extensionPoints>
<extensionPoint name="dynamicEP" dynamic="true"/>
<<warning descr="Non-dynamic extension point 'myPlugin.nonDynamicEP'">extensionPoint</warning> name="nonDynamicEP"/>
<<warning descr="Explicit non-dynamic extension point 'myPlugin.explicitNonDynamicEP'">extensionPoint</warning> name="explicitNonDynamicEP" dynamic="false"/>
<extensionPoint name="explicitNonDynamicEP" dynamic="false"/>
</extensionPoints>
<extensions defaultExtensionNs="myPlugin">
<dynamicEP/>
<nonDynamicEP/>
<explicitNonDynamicEP/>
</extensions>
<actions>
<group id="requiredIdIsPresent"/>
<<warning descr="'id' must be specified for <group>">group</warning>>
@@ -23,7 +20,6 @@
</group>
</actions>
<<warning descr="Non-dynamic plugin due to using components. Migration Guide">application-components</warning>>
</application-components>
plugins/devkit/devkit-java-tests/testData/codeInsight/pluginXmlDynamicPluginInspection/pluginXmlDynamicPluginInspection-usingExtensionPoints.xml
+1 -4
View File
@@ -1,17 +1,14 @@
<idea-plugin>
<id>myPlugin</id>
<extensionPoints>
<extensionPoint name="dynamicEP" dynamic="true"/>
<<warning descr="Non-dynamic extension point 'myPlugin.nonDynamicEP'">extensionPoint</warning> name="nonDynamicEP"/>
<<warning descr="Explicit non-dynamic extension point 'myPlugin.explicitNonDynamicEP'">extensionPoint</warning> name="explicitNonDynamicEP" dynamic="false"/>
<extensionPoint name="explicitNonDynamicEP" dynamic="false"/>
</extensionPoints>
<extensions defaultExtensionNs="myPlugin">
<dynamicEP/>
<<warning descr="Usage of non-dynamic extension point 'myPlugin.nonDynamicEP'">nonDynamicEP</warning>/>
<<warning descr="Usage of non-dynamic extension point 'myPlugin.explicitNonDynamicEP'">explicitNonDynamicEP</warning>/>
</extensions>
</idea-plugin>