MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

AssertWithSideEffects tests migrated to LightCodeInsightFixtureTestCase

Browse Source 
An example of using LightTestMigration
This commit is contained in:
Tagir Valeev
2018-09-06 20:15:02 +07:00
parent 0bb1ade5dc
commit 2f2bfb0a97
6 changed files with 45 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/assert_with_side_effects/AssertWithSideEffects.java
+3 -3
View File
@@ -10,11 +10,11 @@ public class AssertWithSideEffects {
}
void bar(int i) {
assert i++ < 10;
<warning descr="'assert' has side effects">assert</warning> i++ < 10;
}
void abc() {
assert isSideEffect();
<warning descr="'assert' has side effects">assert</warning> isSideEffect();
}
boolean isSideEffect() {
@@ -28,6 +28,6 @@ public class AssertWithSideEffects {
}
void jdbc(ResultSet rs) throws SQLException {
assert rs.last();
<warning descr="'assert' has side effects">assert</warning> rs.last();
}
}
plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/assert_with_side_effects/expected.xml
-23
View File
@@ -1,23 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
<problems>
<problem>
<file>AssertWithSideEffects.java</file>
<line>13</line>
<problem_class>'assert' statement with side effects</problem_class>
<description>&lt;code&gt;assert&lt;/code&gt; has side effects #loc</description>
</problem>
<problem>
<file>AssertWithSideEffects.java</file>
<line>17</line>
<problem_class>'assert' statement with side effects</problem_class>
<description>&lt;code&gt;assert&lt;/code&gt; has side effects #loc</description>
</problem>
<problem>
<file>AssertWithSideEffects.java</file>
<line>31</line>
<problem_class severity="WARNING" attribute_key="WARNING_ATTRIBUTES">'assert' statement with side effects</problem_class>
<description>&lt;code&gt;assert&lt;/code&gt; has side effects #loc</description>
</problem>
</problems>
plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/assert_with_side_effects8/AssertWithSideEffects.java
+2 -2
View File
@@ -4,13 +4,13 @@ import java.util.*;
public class AssertWithSideEffects {
void assertMutation() {
Matcher m = Pattern.compile("foobar").matcher("foo");
assert m.matches();
<warning descr="'assert' has side effects">assert</warning> m.matches();
assert Pattern.compile("foobar").matcher("foo").matches();
}
void assertMutation(Set<String> set) {
assert set.add("foo");
<warning descr="'assert' has side effects">assert</warning> set.add("foo");
assert new HashSet<>().add("bar");
plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/assert_with_side_effects8/expected.xml
-15
View File
@@ -1,15 +0,0 @@
<?xml version="1.0" encoding="UTF-8"?>
<problems>
<problem>
<file>AssertWithSideEffects.java</file>
<line>7</line>
<problem_class>'assert' statement with side effects</problem_class>
<description>&lt;code&gt;assert&lt;/code&gt; has side effects #loc</description>
</problem>
<problem>
<file>AssertWithSideEffects.java</file>
<line>13</line>
<problem_class>'assert' statement with side effects</problem_class>
<description>&lt;code&gt;assert&lt;/code&gt; has side effects #loc</description>
</problem>
</problems>
plugins/InspectionGadgets/testsrc/com/siyeh/ig/bugs/AssertWithSideEffectsInspection8Test.java
+19 -11
View File
@@ -1,20 +1,28 @@
// Copyright 2000-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
package com.siyeh.ig.bugs;
import com.intellij.openapi.projectRoots.Sdk;
import com.intellij.testFramework.IdeaTestUtil;
import com.intellij.testFramework.PsiTestUtil;
import com.siyeh.ig.IGInspectionTestCase;
import com.intellij.testFramework.LightProjectDescriptor;
import com.intellij.testFramework.fixtures.LightCodeInsightFixtureTestCase;
import org.jetbrains.annotations.NotNull;
public class AssertWithSideEffectsInspection8Test extends IGInspectionTestCase {
public class AssertWithSideEffectsInspection8Test extends LightCodeInsightFixtureTestCase {
@Override
protected Sdk getTestProjectSdk() {
// uses Regex
return PsiTestUtil.addJdkAnnotations(IdeaTestUtil.getMockJdk18());
protected String getBasePath() {
return "/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/assert_with_side_effects8";
}
public void test() {
doTest("com/siyeh/igtest/bugs/assert_with_side_effects8",
new AssertWithSideEffectsInspection());
@NotNull
@Override
protected LightProjectDescriptor getProjectDescriptor() {
return JAVA_8_ANNOTATED;
}
private void doTest() {
myFixture.enableInspections(new AssertWithSideEffectsInspection());
myFixture.testHighlighting(getTestName(false) + ".java");
}
public void testAssertWithSideEffects() {
doTest();
}
}
plugins/InspectionGadgets/testsrc/com/siyeh/ig/bugs/AssertWithSideEffectsInspectionTest.java
+21 -11
View File
@@ -1,19 +1,29 @@
// Copyright 2000-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
package com.siyeh.ig.bugs;
import com.intellij.openapi.projectRoots.Sdk;
import com.intellij.testFramework.IdeaTestUtil;
import com.intellij.testFramework.PsiTestUtil;
import com.siyeh.ig.IGInspectionTestCase;
import com.intellij.testFramework.LightProjectDescriptor;
import com.intellij.testFramework.fixtures.LightCodeInsightFixtureTestCase;
import org.jetbrains.annotations.NotNull;
public class AssertWithSideEffectsInspectionTest extends IGInspectionTestCase {
public class AssertWithSideEffectsInspectionTest extends LightCodeInsightFixtureTestCase {
@Override
protected Sdk getTestProjectSdk() {
// uses SQL
return PsiTestUtil.addJdkAnnotations(IdeaTestUtil.getMockJdk17());
protected String getBasePath() {
return "/plugins/InspectionGadgets/test/com/siyeh/igtest/bugs/assert_with_side_effects";
}
public void test() {
doTest("com/siyeh/igtest/bugs/assert_with_side_effects",
new AssertWithSideEffectsInspection());
@NotNull
@Override
protected LightProjectDescriptor getProjectDescriptor() {
// uses SQL
return JAVA_1_7_ANNOTATED;
}
private void doTest() {
myFixture.enableInspections(new AssertWithSideEffectsInspection());
myFixture.testHighlighting(getTestName(false) + ".java");
}
public void testAssertWithSideEffects() {
doTest();
}
}