MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

CustomMethodHandlers: skip() fixed

Browse Source
This commit is contained in:
Tagir Valeev
2019-01-23 17:25:56 +07:00
parent b78db0937d
commit 2e29bb33e8
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/CustomMethodHandlers.java
+1 -1
View File
@@ -245,7 +245,7 @@ class CustomMethodHandlers {
if (arguments.length != 1) return null;
LongRangeSet range = state.getValueFact(arguments[0], DfaFactType.RANGE);
if (range == null || range.isEmpty()) return null;
return factory.getFactValue(DfaFactType.RANGE, LongRangeSet.range(0, range.max()));
return factory.getFactValue(DfaFactType.RANGE, LongRangeSet.range(0, Math.max(0, range.max())));
}
private static Object getConstantValue(DfaMemoryState memoryState, DfaValue value) {
java/java-tests/testData/inspection/dataFlow/fixture/LongRangeKnownMethods.java
+1
View File
@@ -319,5 +319,6 @@ public class LongRangeKnownMethods {
long skipped = is.skip(amount);
if (<warning descr="Condition 'skipped > Integer.MAX_VALUE' is always 'false'">skipped > Integer.MAX_VALUE</warning>) {}
if (<warning descr="Condition 'skipped < 0' is always 'false'">skipped < 0</warning>) {}
if (<warning descr="Condition 'is.skip(-1) == 0' is always 'true'">is.skip(-1) == 0</warning>) {}
}
}