MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-85620 (Inspection "'StringBuffer' can be replaced with 'String'" produces invalid code.)

Browse Source
This commit is contained in:
Bas Leijdekkers
2012-05-07 10:56:53 +02:00
parent cdd823f7fb
commit 2ca03e447b
4 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/InspectionGadgets/src/com/siyeh/ig/style/StringBufferReplaceableByStringInspection.java
+2 -2
View File
@@ -154,7 +154,7 @@ public class StringBufferReplaceableByStringInspection extends BaseInspection {
final PsiExpression argument = arguments[0];
if (result.length() != 0) {
result.append('+');
if (ParenthesesUtils.getPrecedence(argument) > ParenthesesUtils.ADDITIVE_PRECEDENCE) {
if (ParenthesesUtils.getPrecedence(argument) >= ParenthesesUtils.ADDITIVE_PRECEDENCE) {
result.append('(').append(argument.getText()).append(')');
}
else {
@@ -167,7 +167,7 @@ public class StringBufferReplaceableByStringInspection extends BaseInspection {
result.append("String.valueOf(").append(argument.getText()).append(")");
}
else {
if (ParenthesesUtils.getPrecedence(argument) > ParenthesesUtils.ADDITIVE_PRECEDENCE) {
if (ParenthesesUtils.getPrecedence(argument) >= ParenthesesUtils.ADDITIVE_PRECEDENCE) {
result.append('(').append(argument.getText()).append(')');
}
else {
plugins/InspectionGadgets/test/com/siyeh/igfixes/style/replace_with_string/Precedence2.after.java
+8
View File
@@ -0,0 +1,8 @@
package com.siyeh.igfixes.style.replace_with_string;
class Precedence2 {
void foo() {
long start = 0, end = 0;
String string = "Time: " + (end - start) + ".";
}
}
plugins/InspectionGadgets/test/com/siyeh/igfixes/style/replace_with_string/Precedence2.java
+8
View File
@@ -0,0 +1,8 @@
package com.siyeh.igfixes.style.replace_with_string;
class Precedence2 {
void foo() {
long start = 0, end = 0;
String string = new StringB<caret>uilder().append("Time: ").append(end - start).append(".").toString();
}
}
plugins/InspectionGadgets/testsrc/com/siyeh/ig/fixes/style/StringBufferReplaceableWithStringFixTest.java
+1
View File
@@ -35,4 +35,5 @@ public class StringBufferReplaceableWithStringFixTest extends IGQuickFixesTestCa
public void testStringBufferVariable2() { doTest(); }
public void testStartsWithPrimitive() { doTest(); }
public void testPrecedence() { doTest("Precedence", InspectionGadgetsBundle.message("string.builder.replaceable.by.string.quickfix")); }
public void testPrecedence2() { doTest("Precedence2", InspectionGadgetsBundle.message("string.builder.replaceable.by.string.quickfix")); }
}