[java-dfa] Fix regression in closure handling (IDEA-361818)

GitOrigin-RevId: 6accc00522e4f05e5b011cf30858bf3d061e6158

java/java-tests/testData/inspection/dataFlow/fixture/ClosureInConstructor.java

@@ -0,0 +1,19 @@
+import org.jetbrains.annotations.Nullable;
+
+class A {
+  private @Nullable Object obj;
+
+  A() {
+    Runnable r = new Runnable() {
+      @Override
+      public void run() {
+        if (obj == null) {
+          System.out.println("oops");
+        }
+      }
+    };
+    obj = "hello";
+    r.run();
+  }
+
+}

java/java-tests/testSrc/com/intellij/java/codeInspection/DataFlowInspectionTest.java

@@ -763,4 +763,5 @@ public class DataFlowInspectionTest extends DataFlowInspectionTestCase {
   public void testFieldLocalNoAliasing() { doTest();}
   public void testIoContracts() { doTest(); }
   public void testGetTernary() { doTest(); }
+  public void testClosureInConstructor() { doTest(); }
 }

platform/analysis-impl/src/com/intellij/codeInspection/dataFlow/memory/DfaMemoryStateImpl.java

@@ -1766,7 +1766,7 @@ public class DfaMemoryStateImpl implements DfaMemoryState {
     private @NotNull QualifierStatus calculate(@NotNull DfaValue qualifier) {
       final DfType dfType = getDfType(qualifier);
       if (dfType.isImmutableQualifier()) return QualifierStatus.SHOULD_NOT_FLUSH;
-      if (dfType.isLocal()) {
+      if (dfType.isLocal() && !myClosure) {
         return myQualifiersToFlush != null && myQualifiersToFlush.contains(qualifier) ?
                QualifierStatus.SHOULD_FLUSH_ALWAYS : QualifierStatus.SHOULD_NOT_FLUSH;
       }