mirror of
https://gitflic.ru/project/openide/openide.git
synced 2026-09-27 10:03:11 +07:00
IDEA-74131 Failed to interpolate field: private org.apache.maven.model.Reporting ...
This commit is contained in:
Sergey Evdokimov
+294
-11
@@ -17,28 +17,53 @@ package org.jetbrains.idea.maven.server.embedder;
|
||||
|
||||
import org.apache.maven.model.Model;
|
||||
import org.apache.maven.project.ProjectBuilderConfiguration;
|
||||
import org.apache.maven.project.interpolation.AbstractStringBasedModelInterpolator;
|
||||
import org.apache.maven.project.interpolation.ModelInterpolationException;
|
||||
import org.apache.maven.project.interpolation.StringSearchModelInterpolator;
|
||||
import org.apache.maven.project.path.DefaultPathTranslator;
|
||||
import org.apache.maven.project.path.PathTranslator;
|
||||
import org.codehaus.plexus.interpolation.InterpolationPostProcessor;
|
||||
import org.codehaus.plexus.interpolation.Interpolator;
|
||||
import org.codehaus.plexus.interpolation.StringSearchInterpolator;
|
||||
import org.codehaus.plexus.interpolation.ValueSource;
|
||||
import org.codehaus.plexus.logging.Logger;
|
||||
|
||||
import java.io.File;
|
||||
import java.lang.reflect.Array;
|
||||
import java.lang.reflect.Field;
|
||||
import java.security.AccessController;
|
||||
import java.security.PrivilegedAction;
|
||||
import java.util.*;
|
||||
|
||||
/**
|
||||
* Copy pasted from StringSearchModelInterpolator, but removed code that call field.setAccessible(false) to avoid
|
||||
* concurrent access to the static cache in StringSearchModelInterpolator see IDEA-74131.
|
||||
*/
|
||||
public class CustomModelInterpolator extends AbstractStringBasedModelInterpolator {
|
||||
|
||||
private static final Map<Class<?>, Field[]> fieldsByClass = new WeakHashMap<Class<?>, Field[]>();
|
||||
private static final Map<Class<?>, Boolean> fieldIsPrimitiveByClass = new WeakHashMap<Class<?>, Boolean>();
|
||||
|
||||
public class CustomModelInterpolator extends StringSearchModelInterpolator {
|
||||
public CustomModelInterpolator() {
|
||||
|
||||
}
|
||||
|
||||
public CustomModelInterpolator(DefaultPathTranslator pathTranslator) {
|
||||
public CustomModelInterpolator(PathTranslator pathTranslator) {
|
||||
super(pathTranslator);
|
||||
}
|
||||
|
||||
@Override
|
||||
protected synchronized void interpolateObject(Object obj,
|
||||
Model model,
|
||||
File projectDir,
|
||||
ProjectBuilderConfiguration config,
|
||||
boolean debugEnabled) throws ModelInterpolationException {
|
||||
public Model interpolate(Model model, File projectDir, ProjectBuilderConfiguration config, boolean debugEnabled)
|
||||
throws ModelInterpolationException {
|
||||
interpolateObject(model, model, projectDir, config, debugEnabled);
|
||||
|
||||
return model;
|
||||
}
|
||||
|
||||
protected void interpolateObject(Object obj,
|
||||
Model model,
|
||||
File projectDir,
|
||||
ProjectBuilderConfiguration config,
|
||||
boolean debugEnabled) throws ModelInterpolationException {
|
||||
try {
|
||||
super.interpolateObject(obj, model, projectDir, config, debugEnabled);
|
||||
doInterpolateObject(obj, model, projectDir, config, debugEnabled);
|
||||
}
|
||||
catch (NullPointerException e) {
|
||||
// npe may be thrown from here:
|
||||
@@ -50,4 +75,262 @@ public class CustomModelInterpolator extends StringSearchModelInterpolator {
|
||||
throw new ModelInterpolationException("Cannot interpolate", e);
|
||||
}
|
||||
}
|
||||
|
||||
protected void doInterpolateObject(Object obj, Model model, File projectDir, ProjectBuilderConfiguration config,
|
||||
boolean debugEnabled)
|
||||
throws ModelInterpolationException {
|
||||
try {
|
||||
List<ValueSource> valueSources = createValueSources(model, projectDir, config);
|
||||
List<InterpolationPostProcessor> postProcessors = createPostProcessors(model, projectDir, config);
|
||||
|
||||
InterpolateObjectAction action =
|
||||
new InterpolateObjectAction(obj, valueSources, postProcessors, debugEnabled,
|
||||
this, getLogger());
|
||||
|
||||
ModelInterpolationException error =
|
||||
(ModelInterpolationException)AccessController.doPrivileged(action);
|
||||
|
||||
if (error != null) {
|
||||
throw error;
|
||||
}
|
||||
}
|
||||
finally {
|
||||
getInterpolator().clearAnswers();
|
||||
}
|
||||
}
|
||||
|
||||
protected Interpolator createInterpolator() {
|
||||
StringSearchInterpolator interpolator = new StringSearchInterpolator();
|
||||
interpolator.setCacheAnswers(true);
|
||||
|
||||
return interpolator;
|
||||
}
|
||||
|
||||
private static final class InterpolateObjectAction implements PrivilegedAction<ModelInterpolationException> {
|
||||
|
||||
private final boolean debugEnabled;
|
||||
private final LinkedList<Object> interpolationTargets;
|
||||
private final CustomModelInterpolator modelInterpolator;
|
||||
private final Logger logger;
|
||||
private final List<ValueSource> valueSources;
|
||||
private final List<InterpolationPostProcessor> postProcessors;
|
||||
|
||||
public InterpolateObjectAction(Object target, List<ValueSource> valueSources,
|
||||
List<InterpolationPostProcessor> postProcessors, boolean debugEnabled,
|
||||
CustomModelInterpolator modelInterpolator, Logger logger) {
|
||||
this.valueSources = valueSources;
|
||||
this.postProcessors = postProcessors;
|
||||
this.debugEnabled = debugEnabled;
|
||||
|
||||
this.interpolationTargets = new LinkedList<Object>();
|
||||
interpolationTargets.add(target);
|
||||
|
||||
this.modelInterpolator = modelInterpolator;
|
||||
this.logger = logger;
|
||||
}
|
||||
|
||||
public ModelInterpolationException run() {
|
||||
while (!interpolationTargets.isEmpty()) {
|
||||
Object obj = interpolationTargets.removeFirst();
|
||||
|
||||
try {
|
||||
traverseObjectWithParents(obj.getClass(), obj);
|
||||
}
|
||||
catch (ModelInterpolationException e) {
|
||||
return e;
|
||||
}
|
||||
}
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
@SuppressWarnings("unchecked")
|
||||
private void traverseObjectWithParents(Class<?> cls, Object target)
|
||||
throws ModelInterpolationException {
|
||||
if (cls == null) {
|
||||
return;
|
||||
}
|
||||
|
||||
|
||||
if (cls.isArray()) {
|
||||
evaluateArray(target);
|
||||
}
|
||||
else if (isQualifiedForInterpolation(cls)) {
|
||||
Field[] fields = fieldsByClass.get(cls);
|
||||
if (fields == null) {
|
||||
fields = cls.getDeclaredFields();
|
||||
fieldsByClass.put(cls, fields);
|
||||
}
|
||||
|
||||
for (int i = 0; i < fields.length; i++) {
|
||||
Class<?> type = fields[i].getType();
|
||||
if (isQualifiedForInterpolation(fields[i], type)) {
|
||||
fields[i].setAccessible(true);
|
||||
try {
|
||||
if (String.class == type) {
|
||||
String value = (String)fields[i].get(target);
|
||||
if (value != null) {
|
||||
String interpolated = modelInterpolator.interpolateInternal(value, valueSources, postProcessors, debugEnabled);
|
||||
|
||||
if (!interpolated.equals(value)) {
|
||||
fields[i].set(target, interpolated);
|
||||
}
|
||||
}
|
||||
}
|
||||
else if (Collection.class.isAssignableFrom(type)) {
|
||||
Collection<Object> c = (Collection<Object>)fields[i].get(target);
|
||||
if (c != null && !c.isEmpty()) {
|
||||
List<Object> originalValues = new ArrayList<Object>(c);
|
||||
try {
|
||||
c.clear();
|
||||
}
|
||||
catch (UnsupportedOperationException e) {
|
||||
if (debugEnabled && logger != null) {
|
||||
logger.debug(
|
||||
"Skipping interpolation of field: " + fields[i] + " in: " + cls.getName() + "; it is an unmodifiable collection.");
|
||||
}
|
||||
continue;
|
||||
}
|
||||
|
||||
for (Object value : originalValues) {
|
||||
if (value != null) {
|
||||
if (String.class == value.getClass()) {
|
||||
String interpolated =
|
||||
modelInterpolator.interpolateInternal((String)value, valueSources, postProcessors, debugEnabled);
|
||||
|
||||
if (!interpolated.equals(value)) {
|
||||
c.add(interpolated);
|
||||
}
|
||||
else {
|
||||
c.add(value);
|
||||
}
|
||||
}
|
||||
else {
|
||||
c.add(value);
|
||||
if (value.getClass().isArray()) {
|
||||
evaluateArray(value);
|
||||
}
|
||||
else {
|
||||
interpolationTargets.add(value);
|
||||
}
|
||||
}
|
||||
}
|
||||
else {
|
||||
// add the null back in...not sure what else to do...
|
||||
c.add(value);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
else if (Map.class.isAssignableFrom(type)) {
|
||||
Map<Object, Object> m = (Map<Object, Object>)fields[i].get(target);
|
||||
if (m != null && !m.isEmpty()) {
|
||||
for (Map.Entry<Object, Object> entry : m.entrySet()) {
|
||||
Object value = entry.getValue();
|
||||
|
||||
if (value != null) {
|
||||
if (String.class == value.getClass()) {
|
||||
String interpolated =
|
||||
modelInterpolator.interpolateInternal((String)value, valueSources, postProcessors, debugEnabled);
|
||||
|
||||
if (!interpolated.equals(value)) {
|
||||
try {
|
||||
entry.setValue(interpolated);
|
||||
}
|
||||
catch (UnsupportedOperationException e) {
|
||||
if (debugEnabled && logger != null) {
|
||||
logger.debug("Skipping interpolation of field: " +
|
||||
fields[i] +
|
||||
" (key: " +
|
||||
entry.getKey() +
|
||||
") in: " +
|
||||
cls.getName() +
|
||||
"; it is an unmodifiable collection.");
|
||||
}
|
||||
continue;
|
||||
}
|
||||
}
|
||||
}
|
||||
else {
|
||||
if (value.getClass().isArray()) {
|
||||
evaluateArray(value);
|
||||
}
|
||||
else {
|
||||
interpolationTargets.add(value);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
else {
|
||||
Object value = fields[i].get(target);
|
||||
if (value != null) {
|
||||
if (fields[i].getType().isArray()) {
|
||||
evaluateArray(value);
|
||||
}
|
||||
else {
|
||||
interpolationTargets.add(value);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
catch (IllegalArgumentException e) {
|
||||
throw new ModelInterpolationException("Failed to interpolate field: " + fields[i] + " on class: " + cls.getName(), e);
|
||||
}
|
||||
catch (IllegalAccessException e) {
|
||||
throw new ModelInterpolationException("Failed to interpolate field: " + fields[i] + " on class: " + cls.getName(), e);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
traverseObjectWithParents(cls.getSuperclass(), target);
|
||||
}
|
||||
}
|
||||
|
||||
private boolean isQualifiedForInterpolation(Class<?> cls) {
|
||||
return !cls.getPackage().getName().startsWith("java");
|
||||
}
|
||||
|
||||
private boolean isQualifiedForInterpolation(Field field, Class<?> fieldType) {
|
||||
if (!fieldIsPrimitiveByClass.containsKey(fieldType)) {
|
||||
fieldIsPrimitiveByClass.put(fieldType, Boolean.valueOf(fieldType.isPrimitive()));
|
||||
}
|
||||
|
||||
if (((Boolean)fieldIsPrimitiveByClass.get(fieldType)).booleanValue()) {
|
||||
return false;
|
||||
}
|
||||
|
||||
// if ( fieldType.isPrimitive() )
|
||||
// {
|
||||
// return false;
|
||||
// }
|
||||
|
||||
if ("parent".equals(field.getName())) {
|
||||
return false;
|
||||
}
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
private void evaluateArray(Object target)
|
||||
throws ModelInterpolationException {
|
||||
int len = Array.getLength(target);
|
||||
for (int i = 0; i < len; i++) {
|
||||
Object value = Array.get(target, i);
|
||||
if (value != null) {
|
||||
if (String.class == value.getClass()) {
|
||||
String interpolated = modelInterpolator.interpolateInternal((String)value, valueSources, postProcessors, debugEnabled);
|
||||
|
||||
if (!interpolated.equals(value)) {
|
||||
Array.set(target, i, interpolated);
|
||||
}
|
||||
}
|
||||
else {
|
||||
interpolationTargets.add(value);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user