MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak via this$0 by cached value provider

Browse Source
This commit is contained in:
Maxim.Mossienko
2011-01-24 19:51:46 +03:00
parent 05906b4a00
commit 2b329d4442
1 changed files with 32 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
xml/impl/src/com/intellij/xml/util/AnchorReference.java
+32 -23
View File
@@ -122,29 +122,7 @@ class AnchorReference implements PsiReference, EmptyResolveMessageProvider {
if (file != null) {
CachedValue<Map<String, XmlTag>> value = file.getUserData(ourCachedIdsKey);
if (value == null) {
value = CachedValuesManager.getManager(file.getProject()).createCachedValue(new CachedValueProvider<Map<String, XmlTag>>() {
public Result<Map<String, XmlTag>> compute() {
final Map<String,XmlTag> resultMap = new HashMap<String, XmlTag>();
XmlDocument document = HtmlUtil.getRealXmlDocument(file.getDocument());
final XmlTag rootTag = document != null ? document.getRootTag():null;
if (rootTag != null) {
processXmlElements(rootTag,
new PsiElementProcessor() {
public boolean execute(final PsiElement element) {
final String anchorValue = element instanceof XmlTag ? getAnchorValue((XmlTag)element):null;
if (anchorValue!=null) {
resultMap.put(anchorValue, (XmlTag)element);
}
return true;
}
}
);
}
return new Result<Map<String, XmlTag>>(resultMap, file);
}
}, false);
value = CachedValuesManager.getManager(file.getProject()).createCachedValue(new MapCachedValueProvider(file), false);
file.putUserData(ourCachedIdsKey, value);
}
@@ -239,4 +217,35 @@ class AnchorReference implements PsiReference, EmptyResolveMessageProvider {
XmlBundle.message("cannot.resolve.anchor", myAnchor) :
XmlBundle.message("cannot.resolve.anchor.in.file", myAnchor, xmlFile.getName());
}
// separate static class to avoid memory leak via this$0
private static class MapCachedValueProvider implements CachedValueProvider<Map<String, XmlTag>> {
private final XmlFile myFile;
public MapCachedValueProvider(XmlFile file) {
myFile = file;
}
public Result<Map<String, XmlTag>> compute() {
final Map<String,XmlTag> resultMap = new HashMap<String, XmlTag>();
XmlDocument document = HtmlUtil.getRealXmlDocument(myFile.getDocument());
final XmlTag rootTag = document != null ? document.getRootTag():null;
if (rootTag != null) {
processXmlElements(rootTag,
new PsiElementProcessor() {
public boolean execute(final PsiElement element) {
final String anchorValue = element instanceof XmlTag ? getAnchorValue((XmlTag)element):null;
if (anchorValue!=null) {
resultMap.put(anchorValue, (XmlTag)element);
}
return true;
}
}
);
}
return new Result<Map<String, XmlTag>>(resultMap, myFile);
}
}
}