MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

core: sometimes runnable submitted to StartupManager.runAfterOpened might not be called due to the race between StartupManagerImpl#postStartupActivities and StartupManagerImpl#postStartupActivitiesPassed (IDEA-327074)

Browse Source 
GitOrigin-RevId: 9b0c04f62051950d3c286701846441924a784821
This commit is contained in:
Dmitry Batkovich
2023-08-01 11:46:31 +00:00
committed by intellij-monorepo-bot
parent c89638df65
commit 29ea757566
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/platform-impl/src/com/intellij/ide/startup/impl/StartupManagerImpl.kt
+6 -2
View File
@@ -102,6 +102,8 @@ open class StartupManagerImpl(private val project: Project, private val coroutin
private val lock = Any()
private val initProjectStartupActivities = ArrayDeque<Runnable>()
private val postStartupActivities = ArrayDeque<Runnable>()
@Volatile
private var freezePostStartupActivities = false
@MagicConstant(intValues = [0, DUMB_AWARE_PASSED.toLong(), ALL_PASSED.toLong()])
@Volatile
@@ -270,6 +272,7 @@ open class StartupManagerImpl(private val project: Project, private val coroutin
}
withContext(tracer.span("run post-startup dynamically registered activities")) {
freezePostStartupActivities = true
runActivities(postStartupActivities)
}
postStartupActivitiesPassed = DUMB_AWARE_PASSED
@@ -353,9 +356,9 @@ open class StartupManagerImpl(private val project: Project, private val coroutin
override fun runAfterOpened(runnable: Runnable) {
checkNonDefaultProject()
if (postStartupActivitiesPassed < DUMB_AWARE_PASSED) {
if (!freezePostStartupActivities) {
synchronized(lock) {
if (postStartupActivitiesPassed < DUMB_AWARE_PASSED) {
if (!freezePostStartupActivities) {
postStartupActivities.add(runnable)
return
}
@@ -370,6 +373,7 @@ open class StartupManagerImpl(private val project: Project, private val coroutin
synchronized(lock) {
initProjectStartupActivities.clear()
postStartupActivities.clear()
freezePostStartupActivities = false
}
}