MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-48873 Add easy access to exception stacktrace for exception objects - call getStackTrace only once

Browse Source
This commit is contained in:
Egor Ushakov
2017-11-20 13:16:45 +03:00
parent aa27eeddff
commit 29e5697388
1 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/debugger/impl/src/com/intellij/debugger/ui/impl/watch/FieldDescriptorImpl.java
+11 -3
View File
@@ -84,8 +84,12 @@ public class FieldDescriptorImpl extends ValueDescriptorImpl implements FieldDes
DebuggerManagerThreadImpl.assertIsManagerThread();
try {
if (myObject != null) {
populateExceptionStackTraceIfNeeded(evaluationContext);
return myObject.getValue(myField);
Value fieldValue = myObject.getValue(myField);
if (populateExceptionStackTraceIfNeeded(fieldValue, evaluationContext)) {
// re-read stacktrace value
fieldValue = myObject.getValue(myField);
}
return fieldValue;
}
else {
return myField.declaringType().getValue(myField);
@@ -96,17 +100,21 @@ public class FieldDescriptorImpl extends ValueDescriptorImpl implements FieldDes
}
}
private void populateExceptionStackTraceIfNeeded(EvaluationContextImpl evaluationContext) {
private boolean populateExceptionStackTraceIfNeeded(Value value, EvaluationContextImpl evaluationContext) {
if ("stackTrace".equals(getName()) &&
Registry.is("debugger.populate.exception.stack") &&
value instanceof ArrayReference &&
((ArrayReference)value).length() == 0 &&
DebuggerUtils.instanceOf(myObject.type(), CommonClassNames.JAVA_LANG_THROWABLE)) {
try {
invokeExceptionGetStackTrace(myObject, evaluationContext);
return true;
}
catch (Throwable e) {
LOG.info(e); // catch all exceptions to ensure the method returns gracefully
}
}
return false;
}
public boolean isStatic() {