return mutable list because some strange plugins depend on it (IDEA-CR-48322)

GitOrigin-RevId: 3483b7713002834924fcef517cd3deccb28b44a8
This commit is contained in:
Alexey Kudravtsev
2019-07-02 06:52:16 +03:00
committed by intellij-monorepo-bot
parent 8da4c9c70c
commit 29a60d6d10
4 changed files with 5 additions and 6 deletions
@@ -16,12 +16,12 @@
package com.intellij.openapi.vcs.changes.committed;
import com.intellij.openapi.vcs.versionBrowser.CommittedChangeList;
import com.intellij.util.containers.ContainerUtil;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
import javax.swing.*;
import javax.swing.event.ChangeListener;
import java.util.ArrayList;
import java.util.List;
/**
@@ -79,7 +79,7 @@ public interface ChangeListFilteringStrategy {
@Override
@NotNull
public List<CommittedChangeList> filterChangeLists(List<? extends CommittedChangeList> changeLists) {
return ContainerUtil.immutableList(changeLists);
return new ArrayList<>(changeLists);
}
@Override
@@ -137,7 +137,7 @@ public class ColumnFilteringStrategy implements ChangeListFilteringStrategy {
public List<CommittedChangeList> filterChangeLists(List<? extends CommittedChangeList> changeLists) {
final Object[] selection = myValueList.getSelectedValues();
if (myValueList.getSelectedIndex() == 0 || selection.length == 0) {
return ContainerUtil.immutableList(changeLists);
return new ArrayList<>(changeLists);
}
List<CommittedChangeList> result = new ArrayList<>();
for (CommittedChangeList changeList : changeLists) {
@@ -97,7 +97,7 @@ public class StructureFilteringStrategy implements ChangeListFilteringStrategy {
@NotNull
public List<CommittedChangeList> filterChangeLists(List<? extends CommittedChangeList> changeLists) {
if (mySelection.size() == 0) {
return ContainerUtil.immutableList(changeLists);
return new ArrayList<>(changeLists);
}
final ArrayList<CommittedChangeList> result = new ArrayList<>();
for (CommittedChangeList list : changeLists) {
@@ -17,7 +17,6 @@ import com.intellij.openapi.vcs.RepositoryLocation;
import com.intellij.openapi.vcs.changes.committed.*;
import com.intellij.openapi.vcs.versionBrowser.CommittedChangeList;
import com.intellij.ui.ScrollPaneFactory;
import com.intellij.util.containers.ContainerUtil;
import com.intellij.util.messages.Topic;
import com.intellij.util.ui.JBUI;
import icons.SvnIcons;
@@ -694,7 +693,7 @@ public class RootsAndBranches implements CommittedChangeListDecorator {
@NotNull
public List<CommittedChangeList> filterChangeLists(final List<? extends CommittedChangeList> changeLists) {
if ((!myFilterAlien.mySelected) && (!myFilterNotMerged.mySelected) && (!myFilterMerged.mySelected)) {
return ContainerUtil.immutableList(changeLists);
return new ArrayList<>(changeLists);
}
final List<CommittedChangeList> result = new ArrayList<>();