MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-122792: do not schedule toolbar refresh for partially initialized target component

Browse Source 
this is better fix for 193b3ae

if target component is not shown yet, ModalityState.stateForComponent() will return NON_MODAL, causing memory leak
This commit is contained in:
Aleksey Pivovarov
2015-01-27 16:43:37 +03:00
parent fa9bdb5015
commit 24cbb1e140
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/platform-impl/src/com/intellij/openapi/actionSystem/impl/ActionToolbarImpl.java
+4 -3
View File
@@ -45,6 +45,7 @@ import com.intellij.ui.switcher.SwitchTarget;
import com.intellij.util.containers.ContainerUtil;
import com.intellij.util.ui.JBUI;
import com.intellij.util.ui.UIUtil;
import com.intellij.util.ui.update.UiNotifyConnector;
import org.jetbrains.annotations.NotNull;
import javax.swing.*;
@@ -921,13 +922,13 @@ public class ActionToolbarImpl extends JPanel implements ActionToolbar {
public void setTargetComponent(final JComponent component) {
myTargetComponent = component;
if (myTargetComponent != null && myTargetComponent.isVisible()) {
ApplicationManager.getApplication().invokeLater(new DumbAwareRunnable() {
if (myTargetComponent != null) {
UiNotifyConnector.doWhenFirstShown(myTargetComponent, new DumbAwareRunnable() {
@Override
public void run() {
myUpdater.updateActions(false, false);
}
}, ModalityState.stateForComponent(myTargetComponent));
});
}
}