Use recommended method instead of deprecated

ProjectLevelVcsManager#add/removeVcsListener has been deprecated for
a long time, but some usages were still not updated.
This commit is contained in:
Kirill Likhodedov
2016-10-30 12:49:12 +03:00
parent d0c5b53c5e
commit 24a0e7a809
5 changed files with 12 additions and 10 deletions
@@ -198,6 +198,7 @@ public abstract class ProjectLevelVcsManager {
* @deprecated use {@link #VCS_CONFIGURATION_CHANGED} instead
* @since 6.0
*/
@Deprecated
public abstract void addVcsListener(VcsListener listener);
/**
@@ -207,6 +208,7 @@ public abstract class ProjectLevelVcsManager {
* @deprecated use {@link #VCS_CONFIGURATION_CHANGED} instead
* @since 6.0
*/
@Deprecated
public abstract void removeVcsListener(VcsListener listener);
/**
@@ -25,9 +25,9 @@ package com.intellij.openapi.vcs;
import java.util.EventListener;
/**
* Allows to receive notifications about changes in VCS configuration for the project.
* <p>Allows to receive notifications about changes in VCS configuration for the project.</p>
* <p>Use the {@link ProjectLevelVcsManager#VCS_CONFIGURATION_CHANGED} MessageBus topic to subscribe.</p>
*
* @see ProjectLevelVcsManager#addVcsListener
* @since 6.0
*/
public interface VcsListener extends EventListener {
@@ -63,6 +63,8 @@ import java.util.*;
import java.util.concurrent.*;
import java.util.concurrent.atomic.AtomicReference;
import static com.intellij.openapi.vcs.ProjectLevelVcsManager.*;
@State(name = "ChangeListManager", storages = @Storage(StoragePathMacros.WORKSPACE_FILE))
public class ChangeListManagerImpl extends ChangeListManagerEx implements ProjectComponent, ChangeListOwner, PersistentStateComponent<Element> {
public static final Logger LOG = Logger.getInstance("#com.intellij.openapi.vcs.changes.ChangeListManagerImpl");
@@ -246,14 +248,14 @@ public class ChangeListManagerImpl extends ChangeListManagerEx implements Projec
final ProjectLevelVcsManager vcsManager = ProjectLevelVcsManager.getInstance(myProject);
if (ApplicationManager.getApplication().isUnitTestMode()) {
myUpdater.initialized();
vcsManager.addVcsListener(myVcsListener);
myProject.getMessageBus().connect().subscribe(VCS_CONFIGURATION_CHANGED, myVcsListener);
}
else {
((ProjectLevelVcsManagerImpl)vcsManager).addInitializationRequest(
VcsInitObject.CHANGE_LIST_MANAGER, (DumbAwareRunnable)() -> {
myUpdater.initialized();
broadcastStateAfterLoad();
vcsManager.addVcsListener(myVcsListener);
myProject.getMessageBus().connect().subscribe(VCS_CONFIGURATION_CHANGED, myVcsListener);
});
myConflictTracker.startTracking();
@@ -307,8 +309,6 @@ public class ChangeListManagerImpl extends ChangeListManagerEx implements Projec
@Override
public void projectClosed() {
ProjectLevelVcsManager.getInstance(myProject).removeVcsListener(myVcsListener);
synchronized (myDataLock) {
myUpdateChangesProgressIndicator.cancel();
}
@@ -87,8 +87,8 @@ public class CommittedChangesViewManager implements ChangesViewContentProvider {
}
public JComponent initContent() {
myVcsManager.addVcsListener(myVcsListener);
myConnection = myBus.connect();
myConnection.subscribe(ProjectLevelVcsManager.VCS_CONFIGURATION_CHANGED, myVcsListener);
myConnection.subscribe(CommittedChangesCache.COMMITTED_TOPIC, new MyCommittedChangesListener());
updateChangesContent();
myComponent.refreshChanges(true);
@@ -96,7 +96,6 @@ public class CommittedChangesViewManager implements ChangesViewContentProvider {
}
public void disposeContent() {
myVcsManager.removeVcsListener(myVcsListener);
myConnection.disconnect();
Disposer.dispose(myComponent);
myComponent = null;
@@ -18,7 +18,6 @@ package org.jetbrains.idea.svn.history;
import com.intellij.openapi.application.ApplicationManager;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.ZipperUpdater;
import com.intellij.openapi.vcs.ProjectLevelVcsManager;
import com.intellij.openapi.vcs.VcsListener;
import com.intellij.openapi.vcs.changes.committed.CommittedChangesTreeBrowser;
import com.intellij.openapi.vcs.changes.committed.VcsConfigurationChangeListener;
@@ -34,6 +33,8 @@ import org.jetbrains.idea.svn.mergeinfo.SvnMergeInfoCache;
import java.util.ArrayList;
import java.util.List;
import static com.intellij.openapi.vcs.ProjectLevelVcsManager.VCS_CONFIGURATION_CHANGED;
public class MergeInfoUpdatesListener {
private final static int DELAY = 300;
@@ -77,7 +78,7 @@ public class MergeInfoUpdatesListener {
myConnection.subscribe(SvnVcs.ROOTS_RELOADED, reloadConsumer);
ProjectLevelVcsManager.getInstance(myProject).addVcsListener(new VcsListener() {
myConnection.subscribe(VCS_CONFIGURATION_CHANGED, new VcsListener() {
public void directoryMappingChanged() {
callReloadMergeInfo();
}