default implementation for isAnnotationValid()

This commit is contained in:
Dmitry Avdeev
2016-08-17 13:02:37 +03:00
parent eb93c5f30c
commit 246d7814a5
6 changed files with 2 additions and 18 deletions
@@ -34,5 +34,5 @@ public interface AnnotationProvider extends VcsProviderMarker {
* @param rev File revision to be checked.
* @return true if annotation it valid for the given revision.
*/
boolean isAnnotationValid(@NotNull VcsFileRevision rev);
default boolean isAnnotationValid(@NotNull VcsFileRevision rev) { return true; }
}
@@ -146,7 +146,7 @@ public class VcsAnnotationCachedProxy implements AnnotationProvider {
}
@Override
public boolean isAnnotationValid(VcsFileRevision rev) {
public boolean isAnnotationValid(@NotNull VcsFileRevision rev) {
return myAnnotationProvider.isAnnotationValid(rev);
}
@@ -83,10 +83,6 @@ public class CvsAnnotationProvider implements AnnotationProvider{
return annotate(file, revision.getRevisionNumber().asString(), settings);
}
public boolean isAnnotationValid(VcsFileRevision rev){
return true;
}
public FileAnnotation annotate(VirtualFile cvsVirtualFile, String revision, CvsEnvironment environment) throws VcsException {
// the VirtualFile has a full path if annotate is called from history (when we have a real file on disk),
// and has the path equal to a CVS module name if annotate is called from the CVS repository browser
@@ -249,8 +249,4 @@ public class GitAnnotationProvider implements AnnotationProviderEx, VcsCacheable
}
return new GitFileAnnotation(myProject, virtualFile, revisionNumber, lines);
}
public boolean isAnnotationValid(VcsFileRevision rev) {
return true;
}
}
@@ -80,8 +80,4 @@ public class HgAnnotationProvider implements AnnotationProviderEx {
.getHistory(hgFile.toFilePath(), vcsRoot, myProject, (HgRevisionNumber)revision, -1);
return new HgAnnotation(myProject, hgFile, annotationResult, logResult, revision);
}
public boolean isAnnotationValid(@NotNull VcsFileRevision rev) {
return true;
}
}
@@ -451,10 +451,6 @@ public class SvnAnnotationProvider implements AnnotationProvider, VcsCacheableAn
}
}
public boolean isAnnotationValid( VcsFileRevision rev ){
return true;
}
@Nullable
private static DiffOptions getLogClientOptions(@NotNull SvnVcs vcs) {
return SvnConfiguration.getInstance(vcs.getProject()).isIgnoreSpacesInAnnotate() ? new DiffOptions(true, true, true) : null;