MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

[indexing] Reduce allocations when result is empty

Browse Source 
IntLinkedOpenHashSet allocates quite much (int[] array+long[] array) but in most of the cases they are never filled

GitOrigin-RevId: e3079189f5ac61d511deaaab08b8610ffc42763a
This commit is contained in:
Tagir Valeev
2022-06-11 10:02:23 +00:00
committed by intellij-monorepo-bot
parent b75c52e9fa
commit 237f5b0c59
1 changed files with 19 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/indexing-impl/src/com/intellij/psi/stubs/StubIndexEx.java
+19 -14
View File
@@ -27,6 +27,7 @@ import com.intellij.util.io.VoidDataExternalizer;
import it.unimi.dsi.fastutil.ints.IntIterator;
import it.unimi.dsi.fastutil.ints.IntLinkedOpenHashSet;
import it.unimi.dsi.fastutil.ints.IntSet;
import it.unimi.dsi.fastutil.ints.IntSets;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
@@ -356,23 +357,27 @@ public abstract class StubIndexEx extends StubIndex {
UpdatableIndex<Integer, SerializedStubTree, FileContent, ?> stubUpdatingIndex = fileBasedIndex.getIndex(stubUpdatingIndexId);
try {
IntSet result = new IntLinkedOpenHashSet(); // workaround duplicates keys
// workaround duplicates keys
var action = new ValueContainer.ContainerAction<Void>() {
IntSet result = null;
@Override
public boolean perform(int id, Void value) {
if (finalIdFilter == null || finalIdFilter.containsFileId(id)) {
if (result == null) {
result = new IntLinkedOpenHashSet();
}
result.add(id);
}
return true;
}
};
myAccessValidator.validate(stubUpdatingIndexId, ()-> {
// disable up-to-date check to avoid locks on attempt to acquire index write lock while holding at the same time the readLock for this index
//noinspection Convert2Lambda (workaround for JBR crash, JBR-2349),Convert2Diamond
return FileBasedIndexEx.disableUpToDateCheckIn(() -> ConcurrencyUtil.withLock(stubUpdatingIndex.getLock().readLock(), () ->
index.getData(dataKey).forEach(new ValueContainer.ContainerAction<>() {
@Override
public boolean perform(int id, Void value) {
if (finalIdFilter == null || finalIdFilter.containsFileId(id)) {
result.add(id);
}
return true;
}
})
));
return FileBasedIndexEx.disableUpToDateCheckIn(() -> ConcurrencyUtil.withLock(
stubUpdatingIndex.getLock().readLock(), () -> index.getData(dataKey).forEach(action)));
});
return result;
return action.result == null ? IntSets.EMPTY_SET : action.result;
}
catch (StorageException e) {
forceRebuild(e);