MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IJ-CR-138109 Acquire lock for entire get_instance() call

Browse Source 
This modification streamlines the code as the lock needs to be obtained during the `update_handlers()` call regardless.

GitOrigin-RevId: c5d1d7ce9d3f5c3b81b63b8e6c4a26a72db3e666
This commit is contained in:
Andrey Lisin
2024-06-28 10:51:40 +00:00
committed by intellij-monorepo-bot
parent 0deb09fadb
commit 209c9d230e
1 changed files with 15 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/helpers/pydev/_pydevd_bundle/pydevd_frame_type_handler.py
+15 -22
View File
@@ -216,30 +216,23 @@ class VarsHandler:
self._lock = threading.RLock()
def get_instance(self, group_type):
if group_type == GET_FRAME_NORMAL_GROUP:
if self._instance_normal is None:
with self._lock:
if self._instance_normal is None:
self._init_normal()
instance = self._instance_normal
elif group_type == GET_FRAME_SPECIAL_GROUP:
if self._instance_special is None:
with self._lock:
if self._instance_special is None:
self._init_special()
instance = self._instance_special
else:
if self._instance_return is None:
with self._lock:
if self._instance_return is None:
self._init_return()
instance = self._instance_return
with self._lock:
if instance is not None:
instance.update_handlers()
if group_type == GET_FRAME_NORMAL_GROUP:
if self._instance_normal is None:
self._init_normal()
instance = self._instance_normal
elif group_type == GET_FRAME_SPECIAL_GROUP:
if self._instance_special is None:
self._init_special()
instance = self._instance_special
else:
if self._instance_return is None:
self._init_return()
instance = self._instance_return
return instance
instance.update_handlers()
return instance
def _init_normal(self):
self._instance_normal = DummyVarHandler(