MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-161202 parentheses added if necessary

Browse Source
This commit is contained in:
Tagir Valeev
2016-09-19 16:32:27 +07:00
parent 4ce973ad8a
commit 20185a7339
3 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/java18api/Java8CollectionsApiInspection.java
+3 -1
View File
@@ -34,6 +34,7 @@ import com.intellij.util.containers.ContainerUtil;
import com.siyeh.ig.psiutils.ControlFlowUtils;
import com.siyeh.ig.psiutils.EquivalenceChecker;
import com.siyeh.ig.psiutils.ExpressionUtils;
import com.siyeh.ig.psiutils.ParenthesesUtils;
import one.util.streamex.StreamEx;
import org.jetbrains.annotations.Contract;
import org.jetbrains.annotations.Nls;
@@ -443,7 +444,8 @@ public class Java8CollectionsApiInspection extends BaseJavaBatchLocalInspectionT
if(args.length == 2) {
PsiExpression list = args[0];
PsiExpression comparator = args[1];
String replacement = list.getText()+".sort("+comparator.getText()+")";
String replacement =
ParenthesesUtils.getText(list, ParenthesesUtils.METHOD_CALL_PRECEDENCE) + ".sort(" + comparator.getText() + ")";
if (!FileModificationService.getInstance().preparePsiElementForWrite(element.getContainingFile())) return;
methodCallExpression
.replace(JavaPsiFacade.getElementFactory(project).createExpressionFromText(replacement, methodCallExpression));
java/java-tests/testData/inspection/java8CollectionsApi/afterSortExpression.java
+9
View File
@@ -0,0 +1,9 @@
// "Replace with List.sort" "true"
import java.util.Collections;
import java.util.List;
public class Main {
public static void doSort(List<String> list1, List<String> list2, boolean b) {
(b ? list1 : list2).sort(String.CASE_INSENSITIVE_ORDER);
}
}
java/java-tests/testData/inspection/java8CollectionsApi/beforeSortExpression.java
+9
View File
@@ -0,0 +1,9 @@
// "Replace with List.sort" "true"
import java.util.Collections;
import java.util.List;
public class Main {
public static void doSort(List<String> list1, List<String> list2, boolean b) {
Collections.so<caret>rt(b ? list1 : list2, String.CASE_INSENSITIVE_ORDER);
}
}