MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

ExtractWhileLoopConditionToIfStatementIntention: disable for "true" literal only

Browse Source 
Review ID: IDEA-CR-28930
This commit is contained in:
Tagir Valeev
2018-02-16 10:12:20 +07:00
parent 4698ad9416
commit 1dfdc5e3f9
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/IntentionPowerPak/src/com/siyeh/ipp/whileloop/ExtractWhileLoopConditionToIfStatementIntention.java
+3 -1
View File
@@ -19,6 +19,7 @@ import com.intellij.codeInsight.BlockUtils;
import com.intellij.openapi.project.Project;
import com.intellij.psi.*;
import com.intellij.psi.codeStyle.CodeStyleManager;
import com.intellij.psi.util.PsiUtil;
import com.siyeh.ig.psiutils.BoolUtils;
import com.siyeh.ig.psiutils.ExpressionUtils;
import com.siyeh.ipp.base.Intention;
@@ -32,7 +33,8 @@ public class ExtractWhileLoopConditionToIfStatementIntention extends Intention {
protected PsiElementPredicate getElementPredicate() {
WhileLoopPredicate predicate = new WhileLoopPredicate();
return e -> predicate.satisfiedBy(e) &&
!(ExpressionUtils.computeConstantExpression(((PsiWhileStatement)e.getParent()).getCondition()) instanceof Boolean);
!(ExpressionUtils
.isLiteral(PsiUtil.skipParenthesizedExprDown(((PsiWhileStatement)e.getParent()).getCondition()), Boolean.TRUE));
}
@Override