MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

IDEA-75045 Can't authenticate on GitHub if the password has non-ASCII characters

Browse Source
This commit is contained in:
Oleg Shpynov
2011-10-03 10:44:18 +04:00
parent 6c9da79ca3
commit 1df45dbaf8
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/github/src/org/jetbrains/plugins/github/GithubCreateGistAction.java
-2
View File
@@ -122,8 +122,6 @@ public class GithubCreateGistAction extends DumbAwareAction {
@Override
public void run() {
final HttpClient client = anonymous ? GithubUtil.getHttpClient(null, null) : GithubUtil.getHttpClient(settings.getLogin(), password);
client.getParams().setContentCharset("UTF-8");
final PostMethod method = new PostMethod("https://gist.github.com/gists");
method.addParameters(new NameValuePair[]{
new NameValuePair("description", description),
plugins/github/src/org/jetbrains/plugins/github/GithubUtil.java
+2 -1
View File
@@ -116,7 +116,6 @@ public class GithubUtil {
public static HttpMethod doREST(final String url, final String login, final String password, final String request, final boolean post) throws Exception {
final HttpClient client = getHttpClient(login, password);
client.getParams().setContentCharset("UTF-8");
final String uri = "https://" + getHostByUrl(url) + API_URL + request;
final HttpMethod method = post ? new PostMethod(uri) : new GetMethod(uri);
client.executeMethod(method);
@@ -125,6 +124,7 @@ public class GithubUtil {
public static HttpClient getHttpClient(@Nullable final String login, @Nullable final String password) {
final HttpClient client = new HttpClient();
client.getParams().setContentCharset("UTF-8");
// Configure proxySettings if it is required
final HttpConfigurable proxySettings = HttpConfigurable.getInstance();
if (proxySettings.USE_HTTP_PROXY){
@@ -135,6 +135,7 @@ public class GithubUtil {
}
}
if (login != null && password != null) {
client.getParams().setCredentialCharset("UTF-8");
client.getParams().setAuthenticationPreemptive(true);
client.getState().setCredentials(AuthScope.ANY, new UsernamePasswordCredentials(login, password));
}