MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

avoid memory leak, do not hold DebugProcessImpl

Browse Source
This commit is contained in:
Egor.Ushakov
2017-01-16 19:28:32 +03:00
parent 8183855ffb
commit 1da7e42274
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/debugger/impl/src/com/intellij/debugger/ui/breakpoints/StackCapturingLineBreakpoint.java
+9 -9
View File
@@ -1,5 +1,5 @@
/*
* Copyright 2000-2016 JetBrains s.r.o.
* Copyright 2000-2017 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -22,6 +22,7 @@ import com.intellij.debugger.engine.events.SuspendContextCommandImpl;
import com.intellij.debugger.jdi.StackFrameProxyImpl;
import com.intellij.debugger.memory.utils.StackFrameItem;
import com.intellij.debugger.settings.DebuggerSettings;
import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Comparing;
import com.intellij.openapi.util.Key;
import com.intellij.util.containers.ContainerUtil;
@@ -43,8 +44,6 @@ import java.util.Map;
* @author egor
*/
public class StackCapturingLineBreakpoint extends WildcardMethodBreakpoint {
private final DebugProcessImpl myDebugProcess;
private final String mySignature;
private final int myParamNo;
@@ -53,13 +52,12 @@ public class StackCapturingLineBreakpoint extends WildcardMethodBreakpoint {
private final JavaMethodBreakpointProperties myProperties = new JavaMethodBreakpointProperties();
public StackCapturingLineBreakpoint(DebugProcessImpl debugProcess,
public StackCapturingLineBreakpoint(Project project,
String className,
String methodName,
String methodSignature,
int paramNo) {
super(debugProcess.getProject(), null);
myDebugProcess = debugProcess;
super(project, null);
mySignature = methodSignature;
myParamNo = paramNo;
myProperties.EMULATED = true;
@@ -86,7 +84,8 @@ public class StackCapturingLineBreakpoint extends WildcardMethodBreakpoint {
if (suspendContext != null) {
StackFrameProxyImpl frameProxy = suspendContext.getFrameProxy();
if (frameProxy != null) {
Map<ObjectReference, List<StackFrameItem>> stacks = myDebugProcess.getUserData(CAPTURED_STACKS);
DebugProcessImpl process = suspendContext.getDebugProcess();
Map<ObjectReference, List<StackFrameItem>> stacks = process.getUserData(CAPTURED_STACKS);
if (stacks == null) {
stacks = new LinkedHashMap<ObjectReference, List<StackFrameItem>>() {
@Override
@@ -94,7 +93,7 @@ public class StackCapturingLineBreakpoint extends WildcardMethodBreakpoint {
return size() > MAX_STORED_STACKS;
}
};
myDebugProcess.putUserData(CAPTURED_STACKS, Collections.synchronizedMap(stacks));
process.putUserData(CAPTURED_STACKS, Collections.synchronizedMap(stacks));
}
Value key = ContainerUtil.getOrElse(frameProxy.getArgumentValues(), myParamNo, null);
if (key instanceof ObjectReference) {
@@ -117,7 +116,8 @@ public class StackCapturingLineBreakpoint extends WildcardMethodBreakpoint {
}
public static void track(DebugProcessImpl debugProcess, String classFqn, String methodName, @Nullable String methodSignature, int paramNo) {
StackCapturingLineBreakpoint breakpoint = new StackCapturingLineBreakpoint(debugProcess, classFqn, methodName, methodSignature, paramNo);
StackCapturingLineBreakpoint breakpoint =
new StackCapturingLineBreakpoint(debugProcess.getProject(), classFqn, methodName, methodSignature, paramNo);
breakpoint.createRequest(debugProcess);
}
}