Don't suggest defined unread and unmodified variables in extract method (PY-6391)

python/src/com/jetbrains/python/codeInsight/codeFragment/PyCodeFragmentBuilder.java

@@ -139,9 +139,6 @@ public class PyCodeFragmentBuilder extends PyRecursiveElementVisitor {
         }
         // If declaration is before we look for modifications inside
         if (pos == Position.BEFORE) {
-          if (!isTopLevel(element)) {
-            inElements.add(name);
-          }
           final List<PyElement> list = modifiedInsideMap.get(name);
           boolean modificationSeen = false;
           if (list != null) {
@@ -154,6 +151,9 @@ public class PyCodeFragmentBuilder extends PyRecursiveElementVisitor {
               }
             }
             if (modificationSeen) {
+              if (!isTopLevel(element)) {
+                inElements.add(name);
+              }
               break;
             }
           }

python/testData/refactoring/extractmethod/DefinedBeforeAccessedAfter.after.py

@@ -0,0 +1,9 @@
+def bar():
+    if 11 > 4:
+        print('ok')
+
+
+def main(indices):
+    foo = True
+    bar()
+    return foo

python/testData/refactoring/extractmethod/DefinedBeforeAccessedAfter.before.py

@@ -0,0 +1,5 @@
+def main(indices):
+    foo = True
+    <selection>if 11 > 4:
+        print('ok')</selection>
+    return foo

python/testSrc/com/jetbrains/python/refactoring/PyExtractMethodTest.java

@@ -162,4 +162,9 @@ public class PyExtractMethodTest extends LightMarkedTestCase {
   public void testLocalVarDefinedBeforeModifiedInside() {
     doTest("bar");
   }
+
+  // PY-6391
+  public void testDefinedBeforeAccessedAfter() {
+    doTest("bar");
+  }
 }