[java-inspections] 'Remove pattern variable' fix is available on deconstruction pattern component but produces red code

IDEA-298527

GitOrigin-RevId: 32645ea4938384d31bbe4750c3867e3b00f3fafe

java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/PostHighlightingVisitor.java

@@ -425,13 +425,13 @@ class PostHighlightingVisitor {
         return highlightInfo;
       }
     }
-    else if (parameter instanceof PsiPatternVariable) {
+    else if (parameter instanceof PsiPatternVariable variable) {
       HighlightInfo highlightInfo = checkUnusedParameter(parameter, identifier, null);
       if (highlightInfo != null) {
         if (declarationScope.getParent() instanceof PsiSwitchBlock) {
           QuickFixAction.registerQuickFixAction(highlightInfo, quickFixFactory.createRenameToIgnoredFix(parameter, false));
         }
-        else {
+        else if (!(variable.getPattern() instanceof PsiTypeTestPattern pattern && pattern.getParent() instanceof PsiDeconstructionList)) {
           QuickFixAction.registerQuickFixAction(highlightInfo, quickFixFactory.createDeleteFix(parameter));
         }
         return highlightInfo;

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/removeUnusedVariable/afterPatternVariable2.java

@@ -0,0 +1,10 @@
+// "Remove pattern variable" "true-preview"
+class Test {
+  record Point(double x, double y) {}
+
+  record Rect(Point point1, Point point2) {}
+
+  void foo(Object obj) {
+    if (obj instanceof Rect(Point(double x, double y) point1, Point point2)) {}
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/removeUnusedVariable/afterPatternVariable3.java

@@ -0,0 +1,10 @@
+// "Remove pattern variable" "true-preview"
+class Test {
+  record Point(double x, double y) {}
+
+  record Rect(Point point1, Point point2) {}
+
+  void foo(Object obj) {
+    if (obj instanceof Rect(Point(double x, double y), Point point2) rect) {}
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/removeUnusedVariable/beforePatternVariable2.java

@@ -0,0 +1,10 @@
+// "Remove pattern variable" "true-preview"
+class Test {
+  record Point(double x, double y) {}
+
+  record Rect(Point point1, Point point2) {}
+
+  void foo(Object obj) {
+    if (obj instanceof Rect(Point(double x, double y) point1, Point point2) rect<caret>) {}
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/removeUnusedVariable/beforePatternVariable3.java

@@ -0,0 +1,10 @@
+// "Remove pattern variable" "true-preview"
+class Test {
+  record Point(double x, double y) {}
+
+  record Rect(Point point1, Point point2) {}
+
+  void foo(Object obj) {
+    if (obj instanceof Rect(Point(double x, double y) point1<caret>, Point point2) rect) {}
+  }
+}

java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/removeUnusedVariable/beforePatternVariable4.java

@@ -0,0 +1,10 @@
+// "Remove pattern variable" "false"
+class Test {
+  record Point(double x, double y) {}
+
+  record Rect(Point point1, Point point2) {}
+
+  void foo(Object obj) {
+    if (obj instanceof Rect(Point(double x<caret>, double y) point1, Point point2) rect) {}
+  }
+}