MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-08 15:09:39 +07:00
Code Issues Packages Projects Releases Wiki Activity

java: remove redundant cast: ensure operation priority

Browse Source 
GitOrigin-RevId: cad7c6e31f088f5b9528ee3d35743fd5b4b8ef66
This commit is contained in:
Anna Kozlova
2020-05-25 14:35:33 +02:00
committed by intellij-monorepo-bot
parent 6f00747671
commit 1c2a41050d
3 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
java/java-analysis-impl/src/com/intellij/codeInspection/redundantCast/RemoveRedundantCastUtil.java
View File

@@ -7,6 +7,7 @@ import com.intellij.psi.PsiExpression;
import com.intellij.psi.PsiParenthesizedExpression;
import com.intellij.psi.PsiTypeCastExpression;
import com.intellij.psi.util.PsiPrecedenceUtil;
import com.intellij.psi.util.PsiUtil;
import com.intellij.util.IncorrectOperationException;
import com.siyeh.ig.psiutils.CommentTracker;
@@ -19,8 +20,9 @@ public class RemoveRedundantCastUtil {
PsiExpression operand = castExpression.getOperand();
if (operand instanceof PsiParenthesizedExpression) {
final PsiParenthesizedExpression parExpr = (PsiParenthesizedExpression)operand;
if (!(parent instanceof PsiExpression) ||
!PsiPrecedenceUtil.areParenthesesNeeded(parExpr.getExpression(), (PsiExpression)parent, true)) {
PsiElement topParent = PsiUtil.skipParenthesizedExprUp(parent);
if (!(topParent instanceof PsiExpression) ||
!PsiPrecedenceUtil.areParenthesesNeeded(parExpr.getExpression(), (PsiExpression)topParent, true)) {
operand = parExpr.getExpression();
}
}

7
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCast/afterWithStringConcatenation.java Normal file
View File

@@ -0,0 +1,7 @@
// "Remove redundant cast(s)" "true"
class Test {
{
//c1
String s = "" + (1 - 2);
}
}

7
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/redundantCast/beforeWithStringConcatenation.java Normal file
View File

@@ -0,0 +1,7 @@
// "Remove redundant cast(s)" "true"
class Test {
{
String s = "" + ((in<caret>t)//c1
(1 - 2));
}
}