MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-01-08 06:39:38 +07:00
Code Issues Packages Projects Releases Wiki Activity

create method from usage: do not qualify already qualified ref (IDEA-91041)

Browse Source
This commit is contained in:
Anna Kozlova
2012-09-11 17:31:14 +04:00
parent 6ec981fb45
commit 1bdca6d4e5
3 changed files with 37 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/CreateMethodFromUsageFix.java
View File

@@ -167,7 +167,7 @@ public class CreateMethodFromUsageFix extends CreateFromUsageBaseFix {
}
if (enclosingContext instanceof PsiMethod && methodName.equals(enclosingContext.getName()) &&
PsiTreeUtil.isAncestor(targetClass, parentClass, true)) {
PsiTreeUtil.isAncestor(targetClass, parentClass, true) && !ref.isQualified()) {
FieldConflictsResolver.qualifyReference(ref, method, null);
}

20
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/createMethodFromUsage/afterNoQualification.java Normal file
View File

@@ -0,0 +1,20 @@
// "Create Method 'run'" "true"
class Bug {
interface Foo<X> {
void run(X x);
}
public static void main(String[] args) {
new Foo<Bug>() {
@Override
public void run(Bug o) {
o.run();
}
};
}
private void run() {
<selection>//To change body of created methods use File | Settings | File Templates.</selection>
}
}

16
java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/createMethodFromUsage/beforeNoQualification.java Normal file
View File

@@ -0,0 +1,16 @@
// "Create Method 'run'" "true"
class Bug {
interface Foo<X> {
void run(X x);
}
public static void main(String[] args) {
new Foo<Bug>() {
@Override
public void run(Bug o) {
o.ru<caret>n();
}
};
}
}