MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-21789 Inspection about non-ASCII characters in byte strings doesn't check comments

Browse Source
This commit is contained in:
Mikhail Golubev
2016-12-02 17:26:11 +03:00
parent 483439720c
commit 1b37d51740
3 changed files with 5 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/PyByteLiteralInspection.java
+2 -12
View File
@@ -17,8 +17,6 @@ package com.jetbrains.python.inspections;
import com.intellij.codeInspection.LocalInspectionToolSession;
import com.intellij.codeInspection.ProblemsHolder;
import com.intellij.psi.PsiComment;
import com.intellij.psi.PsiElement;
import com.intellij.psi.PsiElementVisitor;
import com.intellij.psi.PsiFile;
import com.jetbrains.python.PyBundle;
@@ -60,11 +58,8 @@ public class PyByteLiteralInspection extends PyInspection {
}
@Override
public void visitComment(PsiComment node) {
checkString(node, node.getText());
}
private void checkString(PsiElement node, String value) {
public void visitPyStringLiteralExpression(PyStringLiteralExpression node) {
String value = node.getStringValue();
PsiFile file = node.getContainingFile(); // can't cache this in the instance, alas
if (file == null) return;
boolean default_bytes = false;
@@ -101,10 +96,5 @@ public class PyByteLiteralInspection extends PyInspection {
registerProblem(node, "Byte literal contains characters > 255");
}
}
@Override
public void visitPyStringLiteralExpression(PyStringLiteralExpression node) {
checkString(node, node.getStringValue());
}
}
}
python/testData/inspections/InspectionsDisabledInFunctionTypeComments/test.py
+1 -1
View File
@@ -1,5 +1,5 @@
<weak_warning descr="Missing docstring"></weak_warning><warning descr="No encoding specified for file"></warning>def <weak_warning descr="Missing docstring">f</weak_warning>(x):
<warning descr="Byte literal contains characters > 255"><warning descr="Non-ASCII character М in file, but no encoding declared"># type: (b'Моноцикл') -> None</warning></warning>
<warning descr="Non-ASCII character М in file, but no encoding declared"># type: (b'Моноцикл') -> None</warning>
pass
python/testData/inspections/PyByteLiteralInspection/test.py
+2
View File
@@ -1,2 +1,4 @@
# Медведь на моноцикле
<warning descr="Byte literal contains characters > 255">b"aaa�"</warning>
b"24sd"