MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

ControlFlowAnalyzer#visitInstanceOfExpression: exclude check on unresolved type

Browse Source 
Otherwise red code `x instanceof Unresolved` produces also "always false" warning which is quite useless.
This commit is contained in:
Tagir Valeev
2018-11-19 14:51:19 +07:00
parent 1444919460
commit 1a9d66091f
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
java/java-analysis-impl/src/com/intellij/codeInspection/dataFlow/ControlFlowAnalyzer.java
+10 -6
View File
@@ -1606,17 +1606,21 @@ public class ControlFlowAnalyzer extends JavaElementVisitor {
@Override public void visitInstanceOfExpression(PsiInstanceOfExpression expression) {
startElement(expression);
PsiExpression operand = expression.getOperand();
operand.accept(this);
PsiTypeElement checkType = expression.getCheckType();
if (checkType != null) {
operand.accept(this);
PsiType type = checkType.getType();
if (type instanceof PsiClassType) {
type = ((PsiClassType)type).rawType();
}
PsiType type = checkType != null ? checkType.getType() : null;
if (type instanceof PsiClassType) {
type = ((PsiClassType)type).rawType();
}
boolean validInstanceOf = type != null &&
(!(type.getDeepComponentType() instanceof PsiClassType) ||
PsiUtil.resolveClassInType(type.getDeepComponentType()) != null);
if (validInstanceOf) {
addInstruction(new PushInstruction(myFactory.createTypeValue(type, Nullability.NOT_NULL), null));
addInstruction(new InstanceofInstruction(expression, operand, type));
}
else {
addInstruction(new PopInstruction());
pushUnknown();
}