MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

InspectionRVContentProvider: patch the stack trace to make it easier to assign the responsible person in Exception analyser

Browse Source
This commit is contained in:
Tagir Valeev
2018-02-05 11:58:05 +07:00
parent a4a30a9c0c
commit 1a3fb028db
1 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
platform/lang-impl/src/com/intellij/codeInspection/ex/InspectionRVContentProvider.java
+17 -7
View File
@@ -1,6 +1,4 @@
/*
* Copyright 2000-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
*/
// Copyright 2000-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
package com.intellij.codeInspection.ex;
@@ -21,6 +19,7 @@ import com.intellij.openapi.project.Project;
import com.intellij.openapi.util.Comparing;
import com.intellij.openapi.util.Ref;
import com.intellij.openapi.util.text.StringUtil;
import com.intellij.util.ArrayUtil;
import com.intellij.util.ObjectUtils;
import com.intellij.util.containers.MultiMap;
import com.intellij.util.containers.TreeTraversal;
@@ -31,6 +30,7 @@ import org.jetbrains.annotations.Nullable;
import javax.swing.tree.TreeNode;
import javax.swing.tree.TreePath;
import java.text.MessageFormat;
import java.util.*;
import java.util.function.Function;
import java.util.function.UnaryOperator;
@@ -174,10 +174,20 @@ public abstract class InspectionRVContentProvider {
protected static void checkFixClass(InspectionToolPresentation presentation, QuickFix fix, LocalQuickFixWrapper quickFixAction) {
Class class1 = getFixClass(fix);
Class class2 = getFixClass(quickFixAction.getFix());
LOG.assertTrue(class1.equals(class2),
"QuickFix-es with the same family name (" + fix.getFamilyName() + ") should be the same class instances but actually are " + class1.getName() + " and " + class2.getName() + "instances. " +
"Please assign reported exception for the inspection \"" + presentation.getToolWrapper().getTool().getClass() + "\" (\"" +
presentation.getToolWrapper().getShortName() + "\") developer");
if (!class1.equals(class2)) {
String message = MessageFormat.format(
"QuickFix-es with the same family name ({0}) should be the same class instances but actually are {1} and {2} instances. " +
"Please assign reported exception for the inspection \"{3}\" (\"{4}\") developer",
fix.getFamilyName(), class1.getName(), class2.getName(), presentation.getToolWrapper().getTool().getClass(),
presentation.getToolWrapper().getShortName());
AssertionError error = new AssertionError(message);
// Hand-craft a stack-trace to make it easier to find the responsible person
StackTraceElement[] trace = error.getStackTrace();
StackTraceElement crafted = new StackTraceElement(class1.getName(), "getFamilyName", null, -1);
trace = ArrayUtil.prepend(crafted, trace);
error.setStackTrace(trace);
LOG.error(message, error);
}
}