MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

PY-871 False positive on unused inspection

Browse Source
This commit is contained in:
Oleg Shpynov
2010-04-21 20:07:01 +04:00
parent ffe03c7a10
commit 16db40abfb
2 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/codeInsight/controlflow/PyControlFlowBuilder.java
+4 -1
View File
@@ -9,6 +9,7 @@ import com.intellij.openapi.util.Ref;
import com.intellij.psi.PsiElement;
import com.intellij.psi.util.PsiTreeUtil;
import com.jetbrains.python.psi.*;
import com.jetbrains.python.psi.impl.PyAssignmentStatementNavigator;
import com.jetbrains.python.psi.impl.PyAugAssignmentStatementNavigator;
import com.jetbrains.python.psi.impl.PyImportStatementNavigator;
import org.jetbrains.annotations.NotNull;
@@ -127,7 +128,9 @@ public class PyControlFlowBuilder extends PyRecursiveElementVisitor {
final PsiElement[] children = node.getChildren();
// Case of non qualified reference
if (children.length == 0){
final ReadWriteInstruction instruction = new ReadWriteInstruction(myBuilder, node, node.getName(), ReadWriteInstruction.ACCESS.WRITE);
final ReadWriteInstruction.ACCESS access = node.getParent() instanceof PySliceExpression
? ReadWriteInstruction.ACCESS.READ : ReadWriteInstruction.ACCESS.WRITE;
final ReadWriteInstruction instruction = new ReadWriteInstruction(myBuilder, node, node.getName(), access);
myBuilder.addNode(instruction);
myBuilder.checkPending(instruction);
} else {
python/src/com/jetbrains/python/psi/impl/PyAssignmentStatementNavigator.java
+9 -5
View File
@@ -15,11 +15,15 @@ public class PyAssignmentStatementNavigator {
@Nullable
public static PyAssignmentStatement getStatementByTarget(final PsiElement element){
final PyAssignmentStatement parent = PsiTreeUtil.getParentOfType(element, PyAssignmentStatement.class);
if (parent != null){
for (PyExpression expression : parent.getTargets()) {
if (element == expression || element.getParent() == expression){
return parent;
final PyAssignmentStatement assignmentStatement = PsiTreeUtil.getParentOfType(element, PyAssignmentStatement.class);
if (assignmentStatement != null){
for (PyExpression expression : assignmentStatement.getTargets()) {
if (element == expression){
return assignmentStatement;
}
final PsiElement parent = element.getParent();
if (parent == expression && parent.getFirstChild() == element && parent.getLastChild() == element){
return assignmentStatement;
}
}
}