MDS/openide
1
0
Fork 0
mirror of https://gitflic.ru/project/openide/openide.git synced 2026-09-27 10:03:11 +07:00
Code Issues Packages Projects Releases Wiki Activity

Raise a warning on isinstance and issubclass checks with Final (PEP 591) (PY-34945)

Browse Source 
GitOrigin-RevId: c084604a96fbe0c61e149f40da47619e2fc4b12e
This commit is contained in:
Semyon Proshev
2019-07-02 06:52:16 +03:00
committed by intellij-monorepo-bot
parent 9709256ca6
commit 163bddf739
2 changed files with 28 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
python/src/com/jetbrains/python/inspections/PyTypeHintsInspection.kt
+8 -8
View File
@@ -64,7 +64,7 @@ class PyTypeHintsInspection : PyInspection() {
super.visitPyClass(node)
if (node != null) {
val superClassExpressions = node.superClassExpressions.toList()
val superClassExpressions = node.superClassExpressions.asList()
checkPlainGenericInheritance(superClassExpressions)
checkGenericDuplication(superClassExpressions)
@@ -246,7 +246,9 @@ class PyTypeHintsInspection : PyInspection() {
PyTypingTypeProvider.GENERIC,
PyTypingTypeProvider.OPTIONAL,
PyTypingTypeProvider.CLASS_VAR,
PyTypingTypeProvider.NO_RETURN ->
PyTypingTypeProvider.NO_RETURN,
PyTypingTypeProvider.FINAL,
PyTypingTypeProvider.FINAL_EXT ->
registerProblem(base,
"'${it.substringAfterLast('.')}' cannot be used with instance and class checks",
ProblemHighlightType.GENERIC_ERROR)
@@ -275,14 +277,12 @@ class PyTypeHintsInspection : PyInspection() {
val qName = it.qualifiedName
when (qName) {
PyTypingTypeProvider.GENERIC -> {
registerProblem(base, "'Generic' cannot be used with instance and class checks", ProblemHighlightType.GENERIC_ERROR)
return@forEach
}
PyTypingTypeProvider.GENERIC,
PyTypingTypeProvider.UNION,
PyTypingTypeProvider.OPTIONAL,
PyTypingTypeProvider.CLASS_VAR -> {
PyTypingTypeProvider.CLASS_VAR,
PyTypingTypeProvider.FINAL,
PyTypingTypeProvider.FINAL_EXT -> {
registerProblem(base,
"'${qName.substringAfterLast('.')}' cannot be used with instance and class checks",
ProblemHighlightType.GENERIC_ERROR)
python/testSrc/com/jetbrains/python/inspections/PyTypeHintsInspectionTest.java
+20
View File
@@ -342,6 +342,26 @@ public class PyTypeHintsInspectionTest extends PyInspectionTestCase {
"assert issubclass(A, <error descr=\"'Generic' cannot be used with instance and class checks\">C</error>)");
}
// PY-34945
public void testInstanceAndClassChecksOnFinal() {
doTestByText("from typing import TypeVar\n" +
"from typing_extensions import Final\n" +
"\n" +
"T = TypeVar(\"T\")\n" +
"\n" +
"class A:\n" +
" pass\n" +
"\n" +
"assert isinstance(A(), <error descr=\"'Final' cannot be used with instance and class checks\">Final</error>)\n" +
"B = Final\n" +
"assert issubclass(A, <error descr=\"'Final' cannot be used with instance and class checks\">B</error>)\n" +
"\n" +
"assert isinstance(A(), <error descr=\"'Final' cannot be used with instance and class checks\">Final[T]</error>)\n" +
"assert issubclass(A, <error descr=\"'Final' cannot be used with instance and class checks\">B[T]</error>)\n" +
"C = B[T]\n" +
"assert issubclass(A, <error descr=\"'Final' cannot be used with instance and class checks\">C</error>)");
}
// PY-28249
public void testInstanceAndClassChecksOnGenericInheritor() {
doTestByText("from typing import TypeVar, List\n" +